ChatQnA - Adding files for deploy application on ROCm vLLM and ROCm TGI with Helm #949
Conversation
…GI with Helm Signed-off-by: Chingis Yundunov <[email protected]>
chyundunovDatamonsters
requested review from
lianhao and
yongfengdu
as code owners
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
Pls also update the valuesfiles.yaml which is used to sync the helm value files from GenAIInfra to GenAIExamples
|
@chensuyue @yongfengdu I think the CI for AMD roc should be added in the GenAIInfra too. Do you know how to do that? |
Yes, we need it. I will take with AMD team to add the test machine into OPEA CI. And we also need to modify the CI workflow adapt with the rocm test. |
|
Could you rebase the PR with latest changes and address the comments? |
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
besides the embedded comment, please also fix the rebase conflict
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
|
@chyundunovDatamonsters please do a manual rebase locally and fix the following conflict: 
Also, your manual local rebase should fix the CI failure too. |
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…o feature/ChatQnA_k8s # Conflicts: # helm-charts/chatqna/README.md
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
|
Seems like the k8s-rocm K8s cluster has some issues. All running pods are automatically stopped and killed. @chyundunovDatamonsters please check the K8s cluster to make sure there is no node level resource pressure(i.e. cpu, memory, disk, etc.) |
…o feature/ChatQnA_k8s
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
lianhao
left a comment
lianhao
left a comment
There was a problem hiding this comment.
Please fix the following yaml syntax error:
Error: parse error at (tgi/templates/deployment.yaml:101): unexpected "/" in operand
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…GI with Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
for more information, see https://pre-commit.ci
|
The Gaudi tests fail. Please pay attention to this problem. |
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
@chyundunovDatamonsters The gaudi test env should fine now. Please pay attention to my embedded comment above. Thanks! |
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
Fixed |
There was a problem hiding this comment.
All seems ok except for my last unresolved comment. @chyundunovDatamonsters
…sing AMD GPU using Helm Signed-off-by: Chingis Yundunov <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
Signed-off-by: Eero Tamminen <[email protected]>
Introduced also by opea-project#949, and update first README clause to indicate that some of the subservices are conditional. Signed-off-by: Eero Tamminen <[email protected]>
Introduced also by opea-project#949, and update first README clause to indicate that some of the subservices are conditional. Signed-off-by: Eero Tamminen <[email protected]>
Introduced also by #949, and update first README clause to indicate that some of the subservices are conditional. Signed-off-by: Eero Tamminen <[email protected]>
4 participants
Description
Adding files for deploy application on ROCm vLLM and ROCm TGI with Helm
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Tests