[Spotless] Applying Google Code Format for opensearch directory #16 #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
force-pushed
the
dev/sl_GoogleJavaFormat16
branch
from
8aece8a
to
cecba8a
Compare
MitchellGale
changed the title
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1977 +/- ##
============================================
- Coverage 97.51% 97.33% -0.19%
Complexity 4656 4656
============================================
Files 408 408
Lines 11932 12063 +131
Branches 829 829
============================================
+ Hits 11636 11741 +105
- Misses 289 315 +26
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6 tasks
Yury-Fridlyand
previously approved these changes
Aug 17, 2023
...ch/src/main/java/org/opensearch/sql/opensearch/storage/script/filter/lucene/LuceneQuery.java
Outdated
Show resolved
Hide resolved
...earch/sql/opensearch/storage/script/filter/lucene/relevance/FunctionParameterRepository.java
Outdated
Show resolved
Hide resolved
...est/java/org/opensearch/sql/opensearch/response/OpenSearchAggregationResponseParserTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/opensearch/sql/opensearch/response/OpenSearchAggregationResponseParserTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
previously approved these changes
Aug 17, 2023
GumpacG
reviewed
Aug 17, 2023
...c/main/java/org/opensearch/sql/opensearch/request/system/OpenSearchDescribeIndexRequest.java
Outdated
Show resolved
Hide resolved
opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java
Outdated
Show resolved
Hide resolved
…/system/OpenSearchDescribeIndexRequest.java Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
…e/agg/MetricParserHelper.java Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
|
You have compilation errors |
Signed-off-by: Mitchell Gale <[email protected]>
GumpacG
approved these changes
Aug 18, 2023
Yury-Fridlyand
approved these changes
Aug 18, 2023
Yury-Fridlyand
merged commit 56aa572
into
opensearch-project:main
13 of 15 checks passed
This was referenced Aug 18, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…pensearch-project#1977) * spotless apply for OpenSearch P1. Signed-off-by: Mitchell Gale <[email protected]> * Manual spotless changes Signed-off-by: Mitchell Gale <[email protected]> * ignore failures for checkstyles. Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Address PR comment Signed-off-by: Mitchell Gale <[email protected]> * add order list in Content.java Signed-off-by: Mitchell Gale <[email protected]> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/request/system/OpenSearchDescribeIndexRequest.java Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Update opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java Co-authored-by: Guian Gumpac <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Fixing compilation error Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for opensearch directory in project. Sets checkstyle to not fail on failure for opensearch directory.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.