Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loot): add drop rarity embed field #141

Closed
wants to merge 4 commits into from
Closed

feat(loot): add drop rarity embed field #141

wants to merge 4 commits into from

Conversation

iProdigy
Copy link
Member

@iProdigy iProdigy commented Jan 22, 2023 •
edited
Loading

Work towards #139

  • Load NPC drop rates
  • Include drop rarity as embed field
  • Load pickpocket drop rates
  • Load "event" drop rates
  • Clue notifier integration (possibly for another PR)
  • Collection notifier integration (likely for another PR)
  • Min Rarity config (likely for another PR)

image

@iProdigy iProdigy changed the title feat(loot): add drop rarity consideration feat(loot): add drop rarity embed field Jan 22, 2023
pajlada
pajlada reviewed Jan 22, 2023
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
@iProdigy
Copy link
Member Author

iProdigy commented Mar 3, 2023

For context, PR is in draft stage until https://github.com/osrsbox/osrsbox-db is updated to correctly parse latest drop data (or we write the scripts do this parsing ourselves). Note: even more active forks of osrsbox like https://github.com/0xNeffarion/osrsreboxed-db don't have full coverage of relevant wiki pages

@iProdigy iProdigy added the blocked Something out of our power needs to change before proceeding with this issue label Mar 3, 2023
@TomBolks TomBolks mentioned this pull request May 12, 2023
Closed
@iProdigy iProdigy mentioned this pull request Dec 13, 2023
Closed
2 tasks
@iProdigy
Copy link
Member Author

Obtained a more accurate data source, will create another PR

@iProdigy iProdigy closed this Feb 16, 2024
@iProdigy iProdigy deleted the feature/drop-rarity branch February 16, 2024 23:16
@iProdigy iProdigy mentioned this pull request Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada left review comments

Assignees
No one assigned
Labels
blocked Something out of our power needs to change before proceeding with this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iProdigy @pajlada