Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SQL Keywords and Reserved Words to CAPS #699

Open
morgo opened this issue Oct 31, 2018 · 1 comment
Open

Update SQL Keywords and Reserved Words to CAPS #699

morgo opened this issue Oct 31, 2018 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest This PR/issue is accepted in Hacktoberfest. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@morgo
Copy link
Contributor

morgo commented Oct 31, 2018

In #695 we determined that SQL keywords should be in all caps. There are a number of pages that require updating.
@morgo morgo added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 31, 2018
This was referenced Jan 7, 2020
Closed
Closed
Merged
Closed
@wwar wwar mentioned this issue May 30, 2020
Closed
@ran-huang ran-huang added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 5, 2020
@lilin90 lilin90 added the Hacktoberfest This PR/issue is accepted in Hacktoberfest. label Sep 27, 2020
spencerkee added a commit to spencerkee/docs that referenced this issue Oct 30, 2020
@spencerkee
AUTO_INCREMENT: Capitalize sql keywords
7b9e6b4 
why: issue: pingcap#699
This was referenced Oct 30, 2020
Merged
Merged
spencerkee added a commit to spencerkee/docs that referenced this issue Oct 31, 2020
@spencerkee
Capitalize sql keywords in several files
dbfff36 
why: issue: pingcap#699
TomShawn added a commit that referenced this issue Nov 2, 2020
@spencerkee @TomShawn
AUTO_INCREMENT: Capitalize sql keywords (#4116)
5fa98d9 
why: issue: #699

Co-authored-by: TomShawn <[email protected]>
@ti-srebot ti-srebot mentioned this issue Nov 2, 2020
Merged
9 tasks
TomShawn added a commit that referenced this issue Nov 2, 2020
@spencerkee @TomShawn
Capitalize sql keywords in several files (#4117)
8595ca5 
* Capitalize sql keywords in several files

* Capitalize sql keywords in several files

why: issue: #699

* Capitalize explain

Co-authored-by: TomShawn <[email protected]>
This was referenced Nov 2, 2020
Merged
Merged
Merged
Merged
@dveeden
Copy link
Contributor

dveeden commented Nov 24, 2021

Something like https://github.com/dveeden/docs/blob/check_sql/scripts/check-sql.py could be useful.

$ ./scripts/check-sql.py column-pruning.md 

SQL in column-pruning.md needs to be changed to have uppercase keywords.
  On line   15: select a from t where b> 5

  Suggested changes:
  - select a from t where b> 5
  + SELECT a FROM t WHERE b> 5

This was referenced Dec 31, 2021
Merged
Merged
@qiancai qiancai mentioned this issue Mar 18, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. Hacktoberfest This PR/issue is accepted in Hacktoberfest. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@morgo @dveeden @lilin90 @ran-huang