-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions versions used #520
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## dev #520 +/- ##
=======================================
Coverage 72.05% 72.05%
=======================================
Files 90 90
Lines 7747 7747
=======================================
Hits 5582 5582
Misses 2165 2165 ☔ View full report in Codecov by Sentry. |
Tests are breaking for the same reason as the deploy issue. You will need to pull the fix in from dev for this to work. |
f5b805a
to
207a757
Compare
Yep, just rebased it now. |
Prevent "The following action(s) uses node12 which is deprecated" warnings by updating to the current releases of the Actions used. (Node.js 12 is scheduled for removal from Actions runners next month.) Use the current releases instead of `@main` too, as we don't want to be affected by bleeding-edge bugs. Rewrite ::set-output as a write to $GITHUB_OUTPUT instead; the ::save-state and ::set-output commands are also deprecated.
207a757
to
a5caaf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmarshall, can we safely merge this - looks good to me!
I'll do a quick check that those are still the current versions, and then merge it. |
There is a recently released |
Moving from v0 to v1 in PR #520 removed the deprecated service_account_key option, so we need to recode using google-github-actions/auth.
And just a few days later, we have GitHub's deprecation schedule for |
While we're hacking in .github/workflows/*, we should update these actions that we use. Node.js 12 is scheduled to go away for GH Actions in less than four weeks!
Prevent "The following action(s) uses node12 which is deprecated" warnings by updating to the current releases of the Actions used. Use the current releases instead of
@main
too, as we don't want to be affected by bleeding-edge bugs.Rewrite
::set-output
as a write to $GITHUB_OUTPUT instead; the ::save-state and ::set-output commands are also deprecated.(See also populationgenomics/production-pipelines#354, which was similar for production-pipelines.)