Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions versions used #520

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Update GitHub Actions versions used #520

merged 2 commits into from
Sep 18, 2023

Conversation

jmarshall
Copy link
Contributor

While we're hacking in .github/workflows/*, we should update these actions that we use. Node.js 12 is scheduled to go away for GH Actions in less than four weeks!

Prevent "The following action(s) uses node12 which is deprecated" warnings by updating to the current releases of the Actions used. Use the current releases instead of @main too, as we don't want to be affected by bleeding-edge bugs.

Rewrite ::set-output as a write to $GITHUB_OUTPUT instead; the ::save-state and ::set-output commands are also deprecated.

(See also populationgenomics/production-pipelines#354, which was similar for production-pipelines.)

@jmarshall jmarshall marked this pull request as ready for review July 19, 2023 23:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (caa83c1) 72.05% compared to head (207a757) 72.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #520   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          90       90           
  Lines        7747     7747           
=======================================
  Hits         5582     5582           
  Misses       2165     2165           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniaki
Copy link
Contributor

daniaki commented Jul 20, 2023

Tests are breaking for the same reason as the deploy issue. You will need to pull the fix in from dev for this to work.

@jmarshall
Copy link
Contributor Author

Yep, just rebased it now.

Prevent "The following action(s) uses node12 which is deprecated"
warnings by updating to the current releases of the Actions used.
(Node.js 12 is scheduled for removal from Actions runners next month.)
Use the current releases instead of `@main` too, as we don't want to
be affected by bleeding-edge bugs.

Rewrite ::set-output as a write to $GITHUB_OUTPUT instead;
the ::save-state and ::set-output commands are also deprecated.
Copy link
Collaborator

@illusional illusional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarshall, can we safely merge this - looks good to me!

@jmarshall
Copy link
Contributor Author

I'll do a quick check that those are still the current versions, and then merge it.

@jmarshall jmarshall merged commit f128b70 into dev Sep 18, 2023
2 checks passed
@jmarshall jmarshall deleted the update-gh-actions branch September 18, 2023 03:33
@jmarshall
Copy link
Contributor Author

There is a recently released actions/checkout@v4, but I think we can leave that for the next batch in several months…

jmarshall added a commit that referenced this pull request Sep 18, 2023
Moving from v0 to v1 in PR #520 removed the deprecated service_account_key
option, so we need to recode using google-github-actions/auth.
@jmarshall
Copy link
Contributor Author

And just a few days later, we have GitHub's deprecation schedule for actions/checkout@v3: 🙃

GitHub Actions: Transitioning from Node 16 to Node 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants