Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-gcloud@v1 needs a separate gga/auth action #550

Closed
wants to merge 1 commit into from

Conversation

jmarshall
Copy link
Contributor

Moving from v0 to v1 in PR #520 removed the deprecated service_account_key option, which appears to have broken things:

Warning: Unexpected input(s) 'service_account_key', valid inputs are ['skip_install', 'version', 'project_id', 'install_components']
Run google-github-actions/setup-gcloud@v1
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/0cab5d55-ed4d-4507-a4f2-d5285f49ee1c -f /home/runner/work/_temp/8df5102a-6ced-44a0-9f29-c8279d945214
Warning: No authentication found for gcloud, authenticate with `google-github-actions/auth`.
Successfully set default project

Oops!

Apparently we need to recode using a separate google-github-actions/auth action step. This PR does that using service-account-key-json, however it's possible that the secret is no longer in the format expected by this new option and will need to be updated.

Alternatively we could revert to google-github-actions/setup-gcloud@v0, though that will likely eventually cause problems.

Moving from v0 to v1 in PR #520 removed the deprecated service_account_key
option, so we need to recode using google-github-actions/auth.
@illusional
Copy link
Collaborator

Great time to move to federated identities, reduce chance of leaked credentials. I'll follow-up in a PR based on: https://github.com/populationgenomics/cpg-infrastructure-private/blob/34a706ebf3cf492cc8dba7dfa82eafdc2f3bc81d/.github/workflows/deploy.yaml#L50-L59

@jmarshall
Copy link
Contributor Author

Good plan. I didn't realise we already had an example of using federated to follow.

@illusional
Copy link
Collaborator

Closing in favour of #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants