Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate tob-wgs-test metamist with nagim gvcf files #653
base: dev
Are you sure you want to change the base?
Populate tob-wgs-test metamist with nagim gvcf files #653
Changes from 35 commits
a1b5be9
4cb1744
6d77327
cb53231
24ae802
37618f1
f222398
e8025df
f8acb63
a684651
7db6896
5beb48d
2a49cd9
570809a
3d2df80
1a2f22a
6f619d0
2645935
b97ecd2
7f963b7
db607f2
c896d30
beb62f1
57e8e83
ce4f7b9
fef13dc
c1e1b7e
b7ba499
3c131d8
7ee6d51
fb2c690
225f6fd
8196100
2bf2f65
b46e8f8
76eb16f
cf8b604
52d7c3c
1037931
3295307
ebe2689
5239ebd
6c07839
a3839ad
315bc0a
0299f7e
94c7cc5
64310cf
4df08e1
2f66f18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more descriptive to what this means? Including the expected structure of the file, and maybe an anonymised example of the first couple of lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the parameter name because it doesn't actually reflect what we're parsing, here's the new:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you want the project and project ID? You are getting this in the graphql query above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Will get it from the
query_response
and remove the param requirementThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should consider using a namedtuple or data class here to be super clear how this data is organised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's super cool. I've just implemented a dataclass!