OurDNA: Improve project table view and filtering #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusional
changed the title
…dna/update-table-view-and-filtering
…dna/update-table-view-and-filtering
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #742 +/- ##
==========================================
+ Coverage 79.15% 79.79% +0.63%
==========================================
Files 161 168 +7
Lines 13622 14127 +505
==========================================
+ Hits 10782 11272 +490
- Misses 2840 2855 +15 ☔ View full report in Codecov by Sentry. |
…dna/update-table-view-and-filtering
…dna/update-table-view-and-filtering-with-fastapi-upgrade
…dna/update-table-view-and-filtering-with-fastapi-upgrade
…dna/update-table-view-and-filtering-with-fastapi-upgrade
…dna/update-table-view-and-filtering
illusional
commented
Jun 11, 2024
api/routes/web.py
Outdated
| @@ -79,14 +340,14 @@ async def search_by_keyword(keyword: str, connection=get_projectless_db_connecti | |||
| This searches the keyword, in families, participants + samples in the projects | |||
| that you are a part of (automatically). | |||
| """ | |||
| # raise ValueError("Test") | |||
| # raise ValueError('Test') | |||
There was a problem hiding this comment.
Suggested change
| # raise ValueError('Test') |
models/models/web.py
Outdated
| @@ -17,7 +18,7 @@ class WebProject(SMBase): | |||
| class PagingLinks(SMBase): | |||
There was a problem hiding this comment.
Can delete this now
| }) => { | ||
| // Use the combination of category and filterKey to turn that into the correct value | ||
| // Note filterValues is a ParticipantGridFilter object, which has nested keys for each | ||
| // category (except participant). |
There was a problem hiding this comment.
Suggested change
| // category (except participant). | |
| // category. |
| // set name to the filterKey without the .meta prefix | ||
| const name = props.filterKey.replace(/^meta\./, '') | ||
|
|
||
| // if we are filtering on the participant level, check the filterValues directly |
There was a problem hiding this comment.
Suggested change
| // if we are filtering on the participant level, check the filterValues directly |
…dna/update-table-view-and-filtering
…iew-query-refactoring Improved table filtering
…dna/update-table-view-and-filtering
|
Having some issues with the Form component in the ValueFilter, when it's wrapped in a Form, the sizing doesn't work correctly, but if it's removed I can't catch the "on enter" event.
|
dancoates
reviewed
Jun 19, 2024
dancoates
reviewed
Jun 19, 2024
…dna/update-table-view-and-filtering
* tmp * Linting --------- Co-authored-by: Dan Coates <[email protected]> Co-authored-by: Michael Franklin <[email protected]>
jmarshall
reviewed
Jun 26, 2024
| @@ -333,6 +334,7 @@ async def import_pedigree( | |||
| [ | |||
| ParticipantUpsertInternal( | |||
| id=external_participant_ids_map[row.individual_id], | |||
| external_ids={PRIMARY_EXTERNAL_ORG: row.individual_id}, | |||
…dna/update-table-view-and-filtering
jmarshall
reviewed
Jun 26, 2024
jmarshall
reviewed
Jun 26, 2024
Co-authored-by: John Marshall <[email protected]>
jmarshall
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OurDNA RFC: https://docs.google.com/document/d/1bG8oZQdhA3lEeqlvnCZ1n_P1OqaqDBPlMPB7oz275ns/edit#heading=h.sxmryphgwrnn
Aims:
Consider:
Actual changes:
[large changes]:
[unrelated changes]