Minor fixes #985
Merged
Minor fixes #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #985 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 184 184
Lines 15965 15965
=======================================
Hits 13018 13018
Misses 2947 2947 ☔ View full report in Codecov by Sentry. |
MattWellie
reviewed
Nov 4, 2024
| @@ -24,10 +23,10 @@ def get_sg_ids(vds: str) -> list[str]: | |||
| Returns: | |||
| list[str]: A list of sequencing group IDs. | |||
| """ | |||
| return read_vds(to_path(vds)).variant_data.s.collect() | |||
| return read_vds(dataset_path(vds)).variant_data.s.collect() | |||
There was a problem hiding this comment.
I'm personally more a fan of passing the full path to the analysis we want to register on the CLI, instead of this helper method taking half a path as an argument.
There was a problem hiding this comment.
Fair enough, I can change that back.
MattWellie
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to the combiner script, use better config settings to get the dataset name.