Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): backpressure: remove the support for Promethues data source #19953

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Dec 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Our dashboard allows getting back-pressure data from both Prometheus and Meta node directly. However, this makes the frontend code more and more messy and hard to maintain.

This PR removes the support for Prometheus. In next PR you will see the code can be simplified a lot.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

fuyufjh commented Dec 27, 2024

@fuyufjh fuyufjh marked this pull request as ready for review December 27, 2024 15:44
Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh fuyufjh added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 442ff0f Jan 2, 2025
32 of 34 checks passed
@fuyufjh fuyufjh deleted the eric/dashboard_remove_promethues branch January 2, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants