refactor(dashboard): refactor back-pressure calculation #19954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
fuyufjh
changed the title
yufansong
approved these changes
Dec 31, 2024
| return () => { | ||
| clearInterval(interval) | ||
| } | ||
| }, [toast, resetEmbeddedBackPressures]) | ||
|
|
||
| // Get relationId-relationId -> backpressure rate map | ||
| // Convert fragment-level backpressure rate map to relation-level backpressure rate |
There was a problem hiding this comment.
QQ: what is relation-level backpressure rate?
There was a problem hiding this comment.
E.g. backpressure between MVs
fuyufjh
changed the base branch from
eric/dashboard_remove_promethues
to
graphite-base/19954
8 tasks
BugenZhao
approved these changes
Jan 2, 2025
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Based on the previous PR, this PR rewrite the back-pressure calculation code in much less code.
I did this because I am going to add more statistics to the Web dashboard, such as streaming throughput.
Checklist
Documentation
Release note