Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): add throughput (rows/s) metrics #19972

Merged
merged 9 commits into from
Jan 3, 2025
Merged

feat(dashboard): add throughput (rows/s) metrics #19972

merged 9 commits into from
Jan 3, 2025
+257 −243

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Dec 31, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add throughput (rows/s) metrics to the dashboard. Similar to back-pressure, this data was calculated by subtracting 2 data points, so it needs to wait for a while (5 secs) until numbers come out.

Preview:

Screenshot 2024-12-31 at 15.27.37.png

Screenshot 2024-12-31 at 15.10.34.png

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@fuyufjh fuyufjh mentioned this pull request Dec 31, 2024
Merged
8 tasks
@fuyufjh Graphite App
Copy link
Member Author

fuyufjh commented Dec 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fuyufjh fuyufjh mentioned this pull request Dec 31, 2024
Merged
8 tasks
@fuyufjh fuyufjh changed the title rename proto feat(dashboard): add throughput in dashboard Dec 31, 2024
@fuyufjh fuyufjh changed the title feat(dashboard): add throughput in dashboard feat(dashboard): add throughput metrics Dec 31, 2024
@fuyufjh fuyufjh changed the title feat(dashboard): add throughput metrics feat(dashboard): add throughput (rows/s) metrics Dec 31, 2024
@fuyufjh fuyufjh marked this pull request as ready for review December 31, 2024 07:58
xxchan
xxchan approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

proto/monitor_service.proto Outdated Show resolved Hide resolved
yufansong
yufansong approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BugenZhao
BugenZhao approved these changes Jan 2, 2025
View reviewed changes
proto/monitor_service.proto Outdated Show resolved Hide resolved
Base automatically changed from eric/refactor_bp_data to graphite-base/19954 January 2, 2025 07:48
@fuyufjh fuyufjh force-pushed the eric/dashboard_add_throuput branch from 6846271 to 10bcd2a Compare January 3, 2025 05:52
@fuyufjh fuyufjh requested a review from a team as a code owner January 3, 2025 05:52
@fuyufjh fuyufjh requested review from lmatz and removed request for a team January 3, 2025 05:52
@fuyufjh fuyufjh changed the base branch from graphite-base/19954 to main January 3, 2025 05:52
@fuyufjh fuyufjh removed the request for review from lmatz January 3, 2025 05:53
@fuyufjh fuyufjh enabled auto-merge January 3, 2025 06:30
@fuyufjh fuyufjh added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2025
@fuyufjh fuyufjh added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit ada38dc Jan 3, 2025
33 of 35 checks passed
@fuyufjh fuyufjh deleted the eric/dashboard_add_throuput branch January 3, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@xxchan xxchan xxchan approved these changes

@yufansong yufansong yufansong approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuyufjh @BugenZhao @yufansong @xxchan