-
Notifications
You must be signed in to change notification settings - Fork 3
TPP Server #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPP Server #1
Conversation
44027d5 to
21ec181
Compare
DavidSpielman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this package be renamed to noether_ros2 to avoid ambiguity with ROS1 and match how our other ROS2 interfaces (i.e. industrial_calibration_ros2) are named?
21ec181 to
3581104
Compare
|
The repository itself is named The intent is to make end-user transitions from ROS1 to ROS2 less painful by not requiring a name change from |
DavidMerzJr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found one or two real issues. Some stylistic comments/questions/suggestions. Would like to hear your responses to some of these. Great job putting this together!
3581104 to
b546057
Compare
…CMakeLists and package.xml
65c31da to
095c598
Compare
DavidMerzJr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things left, otherwise looks great.
…added and renamed conversion function for flattening into geometry_msgs/PoseArray
7925a02 to
a5b1f4d
Compare
This PR introduces a tool path planning server that runs a tool path planning pipeline based on the YAML configuration input and specified mesh resource and returns the set of planned tool paths.