Skip to content

Conversation

@marip8
Copy link
Member

@marip8 marip8 commented Sep 19, 2025

This PR introduces a tool path planning server that runs a tool path planning pipeline based on the YAML configuration input and specified mesh resource and returns the set of planned tool paths.

@marip8 marip8 force-pushed the feature/tpp-server-new branch 3 times, most recently from 44027d5 to 21ec181 Compare September 19, 2025 14:54
@marip8 marip8 changed the title Draft: TPP Server TPP Server Sep 19, 2025
Copy link

@DavidSpielman DavidSpielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this package be renamed to noether_ros2 to avoid ambiguity with ROS1 and match how our other ROS2 interfaces (i.e. industrial_calibration_ros2) are named?

@marip8 marip8 force-pushed the feature/tpp-server-new branch from 21ec181 to 3581104 Compare September 19, 2025 16:00
@marip8
Copy link
Member Author

marip8 commented Sep 19, 2025

The repository itself is named noether_ros2, but the package is called noether_ros to align with other ROS-Industrial projects that support both ROS1 and ROS2. For example, the packages in industrial_calibration_ros and industrial_calibration_ros2 are both called industrial_calibration_ros. This is the same for other packages like reach_ros/reach_ros2 and pcl_ros in perception_pcl.

The intent is to make end-user transitions from ROS1 to ROS2 less painful by not requiring a name change from <package_name>_ros to <package_name>_ros2. It also makes it easier to port a repo from ROS1 to ROS2 (or vice versa) because you don't have to find-replace all the places where the name is used

Copy link

@DavidMerzJr DavidMerzJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one or two real issues. Some stylistic comments/questions/suggestions. Would like to hear your responses to some of these. Great job putting this together!

@marip8 marip8 force-pushed the feature/tpp-server-new branch from 3581104 to b546057 Compare September 22, 2025 20:06
@marip8 marip8 force-pushed the feature/tpp-server-new branch from 65c31da to 095c598 Compare September 22, 2025 22:29
Copy link

@DavidMerzJr DavidMerzJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things left, otherwise looks great.

@marip8 marip8 force-pushed the feature/tpp-server-new branch from 7925a02 to a5b1f4d Compare September 24, 2025 21:15
@marip8 marip8 merged commit e67d531 into main Sep 24, 2025
6 checks passed
@marip8 marip8 deleted the feature/tpp-server-new branch December 29, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants