Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaitForTopics: let the user inject a callaback to be executed after starting the subscribers #356

Open
wants to merge 20 commits into
base: rolling
Choose a base branch
from
Open

WaitForTopics: let the user inject a callaback to be executed after starting the subscribers #356

wants to merge 20 commits into from
+187 −2

Commits on May 22, 2023

  1. Let the user inject callables after starting subscribers 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed May 22, 2023
    Configuration menu
    Copy the full SHA
    48f4c5a View commit details
    Browse the repository at this point in the history

  2. Add a more extensive sample code 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed May 22, 2023
    Configuration menu
    Copy the full SHA
    3b1c4c2 View commit details
    Browse the repository at this point in the history

  3. Fixed module name in sample file 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b8004ab View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'rolling' into feature/inject-callables 

    Signed-off-by: Giorgio Pintaudi <[email protected]>
    @LastStarDust
    LastStarDust authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3199e7a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Fixed flake8 I100 error: Import statements are in the wrong order 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    095bbff View commit details
    Browse the repository at this point in the history

  2. Fixed other flake8 errors 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ce59bd5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Added sample code to docstring 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2ed7a9e View commit details
    Browse the repository at this point in the history

  2. Renamed test file so that it is discovered by colcon 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    880b3f3 View commit details
    Browse the repository at this point in the history

  3. Fixed race condition when publishing messages before matching with subs 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    177a85a View commit details
    Browse the repository at this point in the history

  4. Removed useless logs 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    525e519 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fixed flake8 errors 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    473e295 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'ROS2/rolling' into feature/inject-calla… 

    …bles

Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c176ada View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Check that the callback is actually called 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    239847d View commit details
    Browse the repository at this point in the history

  2. Print the ros2 topic pub output 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cddd085 View commit details
    Browse the repository at this point in the history

  3. Check both stdout and stderr 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3e4cfd3 View commit details
    Browse the repository at this point in the history

  4. Use shell=True 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b4a15dc View commit details
    Browse the repository at this point in the history

  5. Try without shell=True 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ac0fe1f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Use the rclpy APIs directly to publish a single message 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1621f01 View commit details
    Browse the repository at this point in the history

  2. Fixed flake8 errors 

    Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e92eb67 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'ROS2/rolling' into feature/inject-calla… 

    …bles

Signed-off-by: Pintaudi Giorgio <[email protected]>
    @LastStarDust
    LastStarDust committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    57277d2 View commit details
    Browse the repository at this point in the history