Rollup of 5 pull requests#152089
Conversation
I'm one of the rare cases that does have uv, but doesn't have python installed globally
add a link to the issue fix test stderr
Tune the build configuration for loongarch64-linux targets to speed up rustc. Changes include: - Enable jemalloc and rust thin-lto. - Set codegen-units=1 and disable debug assertions. These changes reduce rustc-perf compile time by ~17%.
Move the query list into a new `rustc_middle::queries` module This moves the query list from `rustc_middle::query` into a new `rustc_middle::queries` module. This splits up the use of the query system from the remaining implementation of it in `rustc_middle::query`, which conceptually belong to `rustc_query_system`. The goal is to let rustc crates define queries with their own `queries` module, and this makes `rustc_middle` also fit this pattern. The inner `queries` module used by the macros are renamed to `query_info`, so it doesn't conflict with the new outer name.
ci: Optimize loongarch64-linux dist builders Tune the build configuration for loongarch64-linux targets to speed up rustc. Changes include: - Enable jemalloc and rust thin-lto. - Set codegen-units=1. These changes reduce rustc-perf compile time by ~17%.
Add uv to the list of possible python runners Fixes the unlikely case that one has uv, but not python, globally installed (It's me, I'm the unlikely case)
… r=jdonszelmann Convert to inline diagnostics in `rustc_interface` For rust-lang#151366 (comment)
…, r=nnethercote Avoid semicolon suggestion when tail expr is error Fixes rust-lang#151610 When the tail expression is Err due to recovery, HIR constructs `StmtKind::Semi(Err(..))`. The suggestion path then uses `stmt.span.with_lo(tail_expr.span.hi())` to target the semicolon, but `stmt.span == tail_expr.span` so the derived span is empty/invalid.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 794495e2b4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 794495e (parent) -> 930ecbc (this PR) Test differencesShow 268 test diffsStage 0
Stage 1
Stage 2
Additionally, 226 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 930ecbcdf8905c5c8549056c73fcabdd8d6e1b3d --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (930ecbc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -3.2%, secondary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.808s -> 477.437s (0.34%) |
Successful merges:
rustc_middle::queriesmodule #151893 (Move the query list into a newrustc_middle::queriesmodule)rustc_interface#152047 (Convert to inline diagnostics inrustc_interface)Failed merges:
rustc_query_systemcleanups #152023 (Somerustc_query_systemcleanups)r? @ghost
Create a similar rollup