-
Notifications
You must be signed in to change notification settings - Fork 497
feat(descriptors): minimize blocking the UI #11310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
🧪 E2E Preview environment🔑 Environment Variables for Local TestingThis is the preview URL for the E2E tests: https://e2e-studio-1ga9prpa2.sanity.dev To run the E2E tests locally, you can use the following environment variables, then run 💬 Remember to build the project first with |
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
⚡️ Editor Performance ReportUpdated Mon, 01 Dec 2025 15:08:27 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
15e97a6 to
df00f00
Compare
cab079b to
2cedbc7
Compare
df00f00 to
63e37aa
Compare
2cedbc7 to
457a4a7
Compare
63e37aa to
e8af851
Compare
457a4a7 to
24cc74c
Compare
|
I've now slightly tweaked it:
|
| let idleScheduler: IdleScheduler | undefined | ||
| const scheduler = | ||
| opts?.scheduler || | ||
| (opts?.pauseDurations | ||
| ? (idleScheduler = new IdleScheduler(opts.pauseDurations)) | ||
| : SYNC_SCHEDULER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I think having just the scheduler as an option is a cleaner API
e8af851 to
952b964
Compare
24cc74c to
81e3e78
Compare
d2f3775 to
8078eab
Compare
81e3e78 to
d0673b2
Compare
8078eab to
7c1fc4d
Compare
d0673b2 to
9dcef2e
Compare
The base branch was changed.
This adds a "pauser" into the descriptor converter which avoids blocking the UI by scheduling idle callbacks. See the comment in the code for justification and potential follow-up work.
9dcef2e to
316b1e2
Compare

Description
This adds a "pauser" into the descriptor converter which avoids blocking the UI by scheduling idle callbacks. See the comment in the code for justification and potential follow-up work.
What to review
This PR.
Testing
N/A.
Notes for release
N/A. Internal only at the moment.