Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rarer Highcaps #34469

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Rarer Highcaps #34469

merged 4 commits into from
Jan 18, 2025

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 16, 2025

About the PR

Seclites now start with medium-capacity cells, meaning you must unlock and build high-capacity cells rather than just getting them free from sec. Seclite power drain has been reduced so that they still last just as long.

Why / Balance

Highcaps are tech-locked, it doesn't make sense for security to get a free supply of them at roundstart. This will nerf cyborgs a bit by removing their free highcap battery, but it isn't hard to change their power drain if this becomes a issue.

Technical details

Changed starting battery of seclite, and its power draw (wattage) in Resources/Prototypes/Entities/Objects/Tools/flashlight.yml

Requirements

Changelog
🆑

  • tweak: Seclites now start with a medium-capacity power cell.
  • tweak: Seclite power draw (wattage) has been reduced to 0.5.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 16, 2025
@Nox38 Nox38 marked this pull request as ready for review January 16, 2025 20:29
@Nox38 Nox38 requested a review from DrSmugleaf as a code owner January 16, 2025 20:29
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 16, 2025
@slarticodefast
Copy link
Member

I don't think they should start with a high cap cell. It kinda makes the research redundant.

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 16, 2025

@slarticodefast Do you think it would be better to reduce cyborg power drain a bit to offset this or just remove the highcap? With the rule for most maps being that cyborg chargers can only be located at the washroom and sci, medcap batteries can be really hard to work with.

@Nox38 Nox38 changed the title Rarer Highcap batteries Rarer Highcaps Jan 16, 2025
@slarticodefast
Copy link
Member

slarticodefast commented Jan 16, 2025

Well, medium capacity power cells are still kinda the dafault and players getting a high cap from sec is more of an exception (or is every single borg powergaming that?). You could do some testing to see how long the borg's battery holds with a medium or high cap with and without activated flashlight at different rates.

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 16, 2025

(or is every single borg powergaming that?).

In my experience, pretty much always, unless they are on a station with a ton of chargers like Cog. As for the drain, I tested it to determine the correct wattage to make the seclite duration unchanged with the new cell.
Cyborg base draw is 0.6, with their flashlight adding an additional 0.2.

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 16, 2025

eh thats probably outside the scope of this PR anyway

@ArtisticRoomba
Copy link
Contributor

Borgs used to powergame hicaps a lot but I've been seeing a downtrend recently on it, not happening as often anymore.

I personally don't mind pushing hicaps behind science, however the long standing systemic problem of science being the ones that distribute the unlocked technology and not the crew should probably be looked at later so that there's a greater incentive for departments to interact with each other, among other things. Right now science can hog all of tech which is suboptimal. (See space-wizards/docs/pull/336)

@deltanedas
Copy link
Contributor

this is good, borgs shouldnt be balanced around having to tax sec every round

@kosticia
Copy link
Contributor

Finally someone did it

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@slarticodefast slarticodefast self-assigned this Jan 17, 2025
@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 17, 2025
@Pumkin69
Copy link

Good change makes the research viable and doesnt change security

Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@beck-thompson beck-thompson merged commit 993b5c4 into space-wizards:master Jan 18, 2025
12 checks passed
@Nox38 Nox38 deleted the Rare-highcaps branch January 20, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants