-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Improve Security gameplay and roundflow #40000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve Security gameplay and roundflow #40000
Conversation
Seems good, ship it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me
The game has suffered many issues with sec not being able to handle antagonists and tiders in an appropriate manner due to how restrictive space law is. These changes will improve sec gameplay tenfold and fix all player facing issues.
LMFAO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder that the changes need conceptual approval from another combat workgroup member (paging @southbridge-fur / @keronshb) as the author cannot self-approve for design as a member of a workgroup
Finally, a way to deal with all those SHITTERS and ANTAGS, viva la greenshift!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should even out the high nukie win rate.
Honestly this might be too little of a buff. Let's just make any crewmember thats not command valid |
Waste of a get... |
3000 remain |
in the grim darkness of the 40,000th issue there is only war |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do well to reduce sec stress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nitpicks.
- Warnings should be issued for a first offense. | ||
- If multiple minor crimes have been committed or it is a repeat offense, 5 minutes per minor crime is the maximum. | ||
## Capital Crimes | ||
- Capital crimes should usually lead to a death sentence or shift lasting detainment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving an option for detainment allows for people to escape. Please fix.
@@ -49,13 +43,13 @@ | |||
[color=#a4885c]Accessory, Attempting, And Intention:[/color] If someone intentionally, knowingly and substantially assists someone in enacting a crime they can be charged with the relevant crimes, such as an engineer giving someone tools, who says they are going to break into an area. Same goes for a clear and solid attempt at a crime, or a person who shows clear intent to act out a crime, such as a syndicate nuclear operative arming a nuke but getting arrested before it goes off, they can still be charged with station-wide destruction. Does not apply to crimes that have an attempted listing already, like attempted murder. | |||
|
|||
## Normal Punishments | |||
- [color=#a4885c]Warning:[/color] For minor crimes, fix the issue, then warn the person not to attempt the crime again. If they still proceed to do it at a later date, a brig time may be better. | |||
- [color=#a4885c]Warning:[/color] For minor crimes, fix the issue, then harmbaton the person not to attempt the crime again. If they still proceed to do it at a later date, a brig time may be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be replaced with magdump.
Doesn't explain how to charge my batong. |
@@ -50,6 +50,7 @@ | |||
- id: Handcuffs | |||
- id: HoloprojectorSecurity | |||
- id: RadioHandheldSecurity | |||
- id: MeleeDebugGib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a big enough buff to security, and is still easily exploitable by their opponents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id: MeleeDebugGib | |
- id: WeaponPistolDebug |
Guys we cant nerf security so hard. This will make nukie winrates go up 101%! |
Validhunters everywhere are hanging up their gas masks now that Sec finally is able to get the job done. Thank you for your service while it lasted. o7 |
|
||
Use common sense and humanity when issuing punishments. You should not always seek out the highest punishment you can, you don't have to always give the maximum time or always look to demote someone. Prisoners cooperating and on good behavior should have their sentences reduced. Always take in account the severity and only charge for what is needed for someone to learn their lesson. | ||
Use common sense and humanity when issuing punishments. You should always seek out the highest punishment you can, you have to always give the maximum time or always look to demote someone. Prisoners cooperating and on good behavior should have their sentences maintained. Always take in account the severity and only charge for what is needed for someone to learn their lesson. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much too lenient. Security officers shouldn't be required to use humanity or common sense as those aren't standard issue items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best buffs they've ever gotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to be the dissenting voice, then. This PR, while funny, fails to actually address the core issue. Which is that Sec can only Neutralize criminals within short range. Give the HOS the nuke codes, and allow them to properly reduce crime on an unprecedented scale.
yeah i think security can be trusted with this power. they have our best interests at heart, after all. good PR |
@@ -49,13 +43,13 @@ | |||
[color=#a4885c]Accessory, Attempting, And Intention:[/color] If someone intentionally, knowingly and substantially assists someone in enacting a crime they can be charged with the relevant crimes, such as an engineer giving someone tools, who says they are going to break into an area. Same goes for a clear and solid attempt at a crime, or a person who shows clear intent to act out a crime, such as a syndicate nuclear operative arming a nuke but getting arrested before it goes off, they can still be charged with station-wide destruction. Does not apply to crimes that have an attempted listing already, like attempted murder. | |||
|
|||
## Normal Punishments | |||
- [color=#a4885c]Warning:[/color] For minor crimes, fix the issue, then warn the person not to attempt the crime again. If they still proceed to do it at a later date, a brig time may be better. | |||
- [color=#a4885c]Warning:[/color] For minor crimes, fix the issue, then harmbaton the person not to attempt the crime again. If they still proceed to do it at a later date, a brig time may be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [color=#a4885c]Warning:[/color] For minor crimes, fix the issue, then harmbaton the person not to attempt the crime again. If they still proceed to do it at a later date, a brig time may be better. | |
- [color=#a4885c]Warning:[/color] For minor crimes, harmbaton the person not to attempt the crime again. If they still proceed to do it at a later date, a magdump and brig time may be better. |
I feel like this is still too much unneeded responsibility for the role. Why should security officers be expected to fix the issue at hand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a maintainer of another codebase, I will be porting these beautiful changes downstream - I would never have thought that fixing security was so easy! We don’t even have security, that’s just how great this is
Finally some proper 1984 |
As a member if the combat focus group, I wholeheartedly support these changes and think they'll vastly improve the game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@@ -8,15 +8,9 @@ | |||
|
|||
## Treatment Of Prisoners | |||
Prisoners still have certain rights that must be upheld by law enforcement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reword this! This implies that prisoners have rights, when they've done nothing but wrongs to get to this point.
About the PR
Minor update to Security to even out some issues that hindered ideal SecOff gameplay.
Why / Balance
Increasing the arsenal of equipment that Security has access to improves the viable choices available to the department; while it can be argued that the new equipment is a bit on the strong side, I expect there to be plenty of counterplay from antagonists and crew alike.
Additionally, the changes introduced to Space Law should allow for a smoother Sec experience, ensuring there is still red tape that has to be respected while enabling officers to perform their job at the fullest.
Technical details
Mostly just yaml.
Media
Requirements
Breaking changes
Changelog
🆑