Checks fail on old builtin using dorny paths filter #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tldahlgren
force-pushed
the
prechecks_fail_on_old_builtin_using_dorny
branch
from
8496dfa to
ccfc72e
Compare
tldahlgren
changed the title
tldahlgren
force-pushed
the
prechecks_fail_on_old_builtin_using_dorny
branch
from
ccfc72e to
b175036
Compare
tldahlgren
changed the title
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
Signed-off-by: tldahlgren <[email protected]>
tldahlgren
force-pushed
the
prechecks_fail_on_old_builtin_using_dorny
branch
from
d412bcb to
c292a54
Compare
alalazo
approved these changes
Jul 10, 2025
This was referenced Jul 14, 2025
mtaillefumier
pushed a commit
to mtaillefumier/spack-packages
that referenced
this pull request
Jul 16, 2025
Signed-off-by: tldahlgren <[email protected]>
jezwilkinson
pushed a commit
to jezwilkinson/spack-packages
that referenced
this pull request
Jul 21, 2025
Signed-off-by: tldahlgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #526 suggested by @alecbcs.
Update: Moved to CI
changesper Alec to stop processing sooner (e.g., prevents running of style and other checks).Example of the failure output can be found at https://github.com/spack/spack-packages/actions/runs/16181717829/job/45679606196?pr=542.
Success (i.e., no offending builtin repo packages) can be seen in https://github.com/spack/spack-packages/actions/runs/16181798079/job/45679839622?pr=542.