Repository navigation
apollo_network_benchmark: fixed theoretical throughput metric in rr mode - #13403
Closed
Conversation
This was referenced Mar 22, 2026
Contributor
Author
|
This change is |
sirandreww-starkware
marked this pull request as ready for review
March 22, 2026 17:11
sirandreww-starkware
force-pushed
the
03-22-apollo_network_benchmark_fixed_theoretical_throughput_metric_in_rr_mode
branch
from
March 30, 2026 11:08
f8bd165 to
698f8e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, localized change to benchmark metrics reporting with no impact on message sending/receiving behavior or protocol logic.
Overview
Fixes
broadcast_message_theoretical_throughputreporting so it only reflects actual broadcast activity.send_stress_test_messagesnow updates theoretical heartbeat/throughput metrics only when the node is actively broadcasting, and explicitly sets throughput to0.0on non-broadcast rounds (e.g., inMode::RoundRobin) to avoid overstating capacity.Written by Cursor Bugbot for commit 698f8e1. This will update automatically on new commits. Configure here.