Repository navigation
apollo_network_benchmark: moved peerID creation files - #12725
Closed
Conversation
This was referenced Feb 19, 2026
|
This change is |
This was referenced Feb 19, 2026
Contributor
Author
This was referenced Feb 19, 2026
sirandreww-starkware
marked this pull request as ready for review
February 19, 2026 07:27
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate
branch
from
February 19, 2026 08:04
f32a6eb to
9fd8303
Compare
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_peerid_creation_files
branch
from
February 19, 2026 08:04
d9248de to
41712e4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| let keypair = Keypair::ed25519_from_bytes(secret_key_bytes) | ||
| .context("Failed to derive keypair from node id")?; | ||
| Ok(keypair.public().to_peer_id().to_string()) | ||
| } |
There was a problem hiding this comment.
New exported function peer_id_from_node_id is unused
Low Severity
The newly added peer_id_from_node_id function is exported (pub) but has no callers anywhere in the codebase — the only match for peer_id_from_node_id is its definition. This may be intentional if an upstack PR in the stack will consume it, but as it stands in this PR, it introduces dead code along with unused anyhow and libp2p imports.
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate
branch
from
March 16, 2026 15:13
9fd8303 to
80cca2e
Compare
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_peerid_creation_files
branch
2 times, most recently
from
March 22, 2026 17:09
140656d to
a94623e
Compare
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate
branch
from
March 22, 2026 17:09
80cca2e to
9bb267b
Compare
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate
branch
from
March 30, 2026 11:08
9bb267b to
3c1df25
Compare
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_moved_peerid_creation_files
branch
from
March 30, 2026 11:08
a94623e to
291ab1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small refactor isolated to benchmark tooling; behavior should remain equivalent aside from removing secret-key logging and adding a new helper.
Overview
Centralizes deterministic peer key generation for the benchmark tooling by introducing
peer_key(withprivate_key_from_node_idandpeer_id_from_node_id) and exporting it from the crate.Updates
stress_test_node.rsto use the shared helper and removes the old inline key derivation (including the previous secret-key logging); addsanyhowto support error context when deriving aPeerId.Written by Cursor Bugbot for commit 291ab1d. This will update automatically on new commits. Configure here.