[sirandreww-starkware]

Note

Low Risk
Pure refactor that relocates metric declarations without changing metric names or runtime logic; risk is limited to potential import/path or linkage issues.

Overview
Moves the define_metrics! declarations for all apollo_network_benchmark gauges/counters/histograms from the apollo_network_benchmark_node binary into a new shared apollo_network_benchmark::metrics module, and exposes it via lib.rs.

Updates the node binary’s metrics.rs to pub use apollo_network_benchmark::metrics::* and drops now-unneeded imports/constants, while keeping the existing registration and helper functions intact.

^{Written by Cursor Bugbot for commit 3c1df25. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: add benchmark runner and deployment configs #12726
• apollo_network_benchmark: fixed theoretical throughput metric in rr mode #13403
• apollo_network_benchmark: moved peerID creation files #12725
• apollo_network_benchmark: moved metric declarations to crate #12724 👈 (View in Graphite)
• apollo_network_benchmark: renamed node binary #12723
• apollo_network_benchmark: added Serialize to args #12722
• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 2 other dependent PRs (#11561 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).