fix: resolve geometry crash, React key warnings, and switch connections#19
fix: resolve geometry crash, React key warnings, and switch connections#191028bc wants to merge 5 commits intotscircuit:mainfrom
Conversation
Added unique key props to the mapped capacitor array in RP2040Circuit.tsx. This resolves the React console warning "Each child in a list should have a unique key prop" detected during the geometry build.
Tied pins 3 and 4 (Ports C and D) to their respective nets on the TS_1187A_B_A_B tactile switches. This completes the electrical path for all physical pads on the footprint and clears the autorouter "missing trace" warnings for these components.
Removed the unsupported _innerhole parameter from the stampboard footprint. This resolves the boolean geometry engine crash during the board render.
Added the pcbPack prop to the main board component to ensure proper sub-circuit arrangement by the geometry engine. Additionally, imported and included KeyCircuit to ensure the tactile switches are rendered on the final board.
|
PR Status: Ready for Review Key Fixes Included: Geometry Engine: Removed the unsupported _innerhole parameter from the PinOutCircuit footprint and enabled pcbPack in index.tsx to resolve boolean rendering crashes. Trace Routing: Completed the electrical paths for SW1 and SW2 in KeyCircuit.tsx by tying redundant pins (3 and 4) to their respective nets, clearing autorouter warnings. React Stability: Added unique key props to mapped capacitors in RP2040Circuit.tsx to resolve console errors. Component Integration: Verified all sub-circuits (including KeyCircuit) are properly imported and placed within the main board component. The preview is live and the board is rendering successfully. Ready for final merge. |
Explicitly assigned the 0402 footprint to resistor R2 in the KeyCircuit sub-circuit. This resolves the pcb_missing_footprint_error and allows the geometry engine to physically render the component on the PCB layout.
1 participant
This PR resolves three critical issues discovered during the hardware-to-code synthesis:
Geometry Engine Crash: Removed unsupported _innerhole parameters from the PinOutCircuit stampboard footprint and implemented pcpPack in the main board configuration to ensure valid geometry generation.
React Prop Warnings: Added unique key={cName} props to the IOVDD capacitor mapping in RP2040Circuit.tsx to resolve console errors during the build process.
Trace Routing Warnings: Tied redundant pins (3 and 4) to their respective nets on the TS_1187A_B_A_B switches in KeyCircuit.tsx. This completes the electrical path for all physical pads on the footprint and clears autorouter "missing trace" warnings.