feat(pam/nativemodel): Add native PAM interface support #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
pam-native-interface
branch
2 times, most recently
from
95e4ed0
to
ed9880d
Compare
3v1n0
force-pushed
the
pam-native-interface
branch
from
ed9880d
to
4e181f1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 85.24% 84.16% -1.09%
==========================================
Files 76 77 +1
Lines 6161 6673 +512
Branches 75 75
==========================================
+ Hits 5252 5616 +364
- Misses 644 740 +96
- Partials 265 317 +52 ☔ View full report in Codecov by Sentry. |
3v1n0
force-pushed
the
pam-native-interface
branch
6 times, most recently
from
aa10a36
to
717dbf0
Compare
|
Ok, this should be open for business now. Sorry for the big diff, but I've basically replicated all the tests we had for the CLI for this interface, so that we can ensure we keep consistency between the two (a part the differences due to the obvious technological aspects). We have various duplicates in the tests setups now, but I'll address those in another PR. The model per se is not big at all and it should be quite simple. |
3v1n0
force-pushed
the
pam-native-interface
branch
from
717dbf0
to
ef5b47e
Compare
denisonbarbosa
requested changes
Jun 24, 2024
3v1n0
force-pushed
the
pam-native-interface
branch
3 times, most recently
from
fe8946e
to
3a10d33
Compare
denisonbarbosa
requested changes
Jun 26, 2024
In case we're logging to a file, we are not bothering PAM output, so let's continue using the default handler
…d file These are used both by tests and actual PAM model, so expose this in a single place to be reused without repetitions
We were managing this from model, but this happened also on error, so let's instead do the stage change only if authentication has been started
3v1n0
force-pushed
the
pam-native-interface
branch
from
2bfcbef
to
b513a5e
Compare
…what it does The tape doesn't really reset the password, it only skips the request so rename it accordingly, so that we can add an actual test that accepts the request
In this test we were switching to local broker, but that's not something that was explicitly stated so do it
We're going to add more types, so let's organize them better
This makes easier to handle the logic in other UIs without having them to keep track of the state or of the previous password themselves
It allows to work with any pam client, regardless they're supporting authd or not
It allows us to use more complex stacks where normal PAM input is required
…error message When replacing the user ID with XXXX's we may not be able to replace the content fully when the string is wrapped. So just consider the final part of the string. See https://github.com/ubuntu/authd/actions/runs/9588429219/job/26440434186
denisonbarbosa
approved these changes
Jun 26, 2024
Reusing the same test cases of the CLI client, tuned to work with the simpler UI that PAM provides
We had this tape in the repository, but it wasn't used, so actually use it
Repeat the tests we have for the CLI interface in the PAM native interface too
3v1n0
force-pushed
the
pam-native-interface
branch
from
32c7775
to
09dede8
Compare
Yeah, that's done. Thanks for your comments. |
3v1n0
added a commit
to 3v1n0/authd
that referenced
this pull request
Jun 27, 2024
…ypes This was intended to be part of ubuntu#314 but it got lost when merging with ubuntu#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to work with any pam client, regardless they're supporting
authd or not (including polkit and ssh)
UDENG-2289
UDENG-3127
Closes: #380