-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pam/qrcodemodel: Use normal-size Qr code when in simple terminals #393
Conversation
d4072a6
to
25486ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 85.26% 85.24% -0.02%
==========================================
Files 76 76
Lines 6140 6161 +21
Branches 74 75 +1
==========================================
+ Hits 5235 5252 +17
- Misses 642 644 +2
- Partials 263 265 +2 ☔ View full report in Codecov by Sentry. |
57da7f2
to
4c3532b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I do have one question before approving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment! Nice work
They are used by bubbletea to improve the rendering so expose them all
If the terminal is not advanced enough to support the more complex utf-8 characters needed to print the small qrcode, just use the simpler implementation via the big qrcode that uses characters that seems to be supported everywhere.
…ypes This was intended to be part of ubuntu#314 but it got lost when merging with ubuntu#393
If the terminal is not advanced enough to support the more complex utf-8
characters needed to print the small qrcode, just use the simpler
implementation via the big qrcode that uses characters that seems to be
supported everywhere.
In fact bigger qrcode use two times the character
█
to do a square, andthis is supported by the normal tty fonts:
Without having to go through building one via
#
's.In theory we can inspect for font support on that, but it's not something we want to
implement for now.
UDENG-3109
Closes: #361