pam/qrcodemodel: Use normal-size Qr code when in simple terminals #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
qrcode-for-tty
branch
2 times, most recently
from
d4072a6
to
25486ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 85.26% 85.24% -0.02%
==========================================
Files 76 76
Lines 6140 6161 +21
Branches 74 75 +1
==========================================
+ Hits 5235 5252 +17
- Misses 642 644 +2
- Partials 263 265 +2 ☔ View full report in Codecov by Sentry. |
3v1n0
force-pushed
the
qrcode-for-tty
branch
2 times, most recently
from
57da7f2
to
4c3532b
Compare
denisonbarbosa
approved these changes
Jun 25, 2024
didrocks
reviewed
Jun 25, 2024
didrocks
approved these changes
Jun 25, 2024
They are used by bubbletea to improve the rendering so expose them all
If the terminal is not advanced enough to support the more complex utf-8 characters needed to print the small qrcode, just use the simpler implementation via the big qrcode that uses characters that seems to be supported everywhere.
3v1n0
added a commit
to 3v1n0/authd
that referenced
this pull request
Jun 27, 2024
…ypes This was intended to be part of ubuntu#314 but it got lost when merging with ubuntu#393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the terminal is not advanced enough to support the more complex utf-8
characters needed to print the small qrcode, just use the simpler
implementation via the big qrcode that uses characters that seems to be
supported everywhere.
In fact bigger qrcode use two times the character
█to do a square, andthis is supported by the normal tty fonts:
Without having to go through building one via
#'s.In theory we can inspect for font support on that, but it's not something we want to
implement for now.
UDENG-3109
Closes: #361