feat: add indexed pgvector file search storage - #278
Draft
franciscojavierarceo wants to merge 5 commits into
Draft
feat: add indexed pgvector file search storage#278franciscojavierarceo wants to merge 5 commits into
franciscojavierarceo wants to merge 5 commits into
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This was referenced Sep 11, 2026
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize this layer with its updated parent after main's
AgentPipelinerefactor (#274), preserving the immediate-base review boundary.Stack layer 2 of 7: #34 foundation → #278 pgvector/CI → #280 contextual retrieval/reranking/configuration → #281 streaming Files → #282 store lifecycle/content → #283 durable batches → #284 streaming/SDK compatibility.
Base:
feat/axum-ogx-integration-v2(#34). Next: #280. Review against the immediate base and land from the bottom of the stack.Adds real PostgreSQL/pgvector candidate retrieval to the in-tree file search service. Deployments can select HNSW or IVFFlat with validated dimensions and index settings; SQLite and plain PostgreSQL retain the existing exact retrieval backend.
Vector data is projected transactionally from stored chunks, including existing rows, so attachment publication and deletion keep metadata and vectors consistent. Search uses database distance operators, typed attribute filters and bounded candidates before shared ranking. IVFFlat waits for sufficient training data; until then it uses bounded database distance retrieval. CI now provisions pgvector and runs the native integration scenarios.
Initial backfill/index construction requires DDL privileges and can lock the table. Replicas must agree on index construction settings; approximate indexes and bounded keyword candidates can differ from exact retrieval. These constraints and configuration examples are documented.
Test Plan
Layer-specific implementation verification:
After synchronization with #274: This updated layer passed locked all-feature workspace compilation, diff checks, and all-files pre-commit hooks. The combined stack in #284 passed 1,389 workspace tests, 31 PostgreSQL/pgvector tests, and 17 maintained SDK cases, plus the Rust 1.88 all-feature check and all-target workspace clippy. The pipeline integration review is complete. GitHub CI is rerunning for the updated heads; previous green checks apply to the prior revisions.