feat: add durable vector store batches and owned workers - #283
Draft
franciscojavierarceo wants to merge 3 commits into
Draft
feat: add durable vector store batches and owned workers#283franciscojavierarceo wants to merge 3 commits into
franciscojavierarceo wants to merge 3 commits into
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This was referenced Sep 11, 2026
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize this layer with its updated parent after main's
AgentPipelinerefactor (#274), preserving the immediate-base review boundary.Stack layer 6 of 7: #34 foundation → #278 pgvector/CI → #280 contextual retrieval/reranking/configuration → #281 streaming Files → #282 store lifecycle/content → #283 durable batches → #284 streaming/SDK compatibility.
Base:
codex/vector-store-lifecycle(#282). Next: #284. Review against the immediate base and land from the bottom of the stack.Adds durable Vector Store file batches: create, retrieve, cancel, and list files with per-file attributes/chunking, filtered pagination, and durable status/counts. Multiple server instances claim bounded jobs with renewable leases and generation fences; cancellation, detach, deletion, expiration, and lost claims prevent stale publication. Completed and failed members remain visible in batch history.
The server now owns and joins the ingestion workers across normal and error exits. Workers resume queued work after restart and run the existing file/store expiration and durable blob cleanup. Shutdown preserves resumability and cooperatively drains owned work; model requests may repeat after recovery, while publication is fenced.
Native batch policy: duplicate IDs and existing non-completed attachments reject atomically; existing completed attachments are reused with their original options. Shared database replicas require a shared Files mount.
Test Plan
Layer-specific implementation verification:
Independent task review and scoped fix review passed. Review regressions reproduce a PostgreSQL post-commit lock timeout and slow-heartbeat starvation; both fixes pass, along with 18 covering SQLite/PostgreSQL batch tests and repeated clippy/pre-commit gates.
After synchronization with #274: This updated layer passed locked all-feature workspace compilation, diff checks, and all-files pre-commit hooks. The combined stack in #284 passed 1,389 workspace tests, 31 PostgreSQL/pgvector tests, and 17 maintained SDK cases, plus the Rust 1.88 all-feature check and all-target workspace clippy. The pipeline integration review is complete. GitHub CI is rerunning for the updated heads; previous green checks apply to the prior revisions.