feat: stream Files API uploads and support expiration - #281
Draft
franciscojavierarceo wants to merge 3 commits into
Draft
feat: stream Files API uploads and support expiration#281franciscojavierarceo wants to merge 3 commits into
franciscojavierarceo wants to merge 3 commits into
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This was referenced Sep 11, 2026
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize this layer with its updated parent after main's
AgentPipelinerefactor (#274), preserving the immediate-base review boundary.Stack layer 4 of 7: #34 foundation → #278 pgvector/CI → #280 contextual retrieval/reranking/configuration → #281 streaming Files → #282 store lifecycle/content → #283 durable batches → #284 streaming/SDK compatibility.
Base:
codex/file-search-retrieval(#280). Next: #282. Review against the immediate base and land from the bottom of the stack.Streams Files API uploads and downloads through bounded buffers, supporting files up to 512 MiB without buffering the whole payload in memory. Multipart metadata is validated before publication; failed or disconnected uploads retain the existing cleanup and durability guarantees.
Adds the documented upload purposes, explicit file expiration and the batch-purpose default, purpose-filtered pagination up to 10000, empty-file support and the correct delete response object. Expired files immediately disappear from reads and retrieval. SQL deletion records durable blob-cleanup intent so later cleanup can recover interrupted filesystem deletion.
Test Plan
Layer-specific implementation verification:
The pinned OpenAI 3.13.0 SDK accepts
purpose="evals"on upload but omits it from its response enum. The server preserves the correctevalswire value; direct HTTP coverage tests it, while the strict SDK expiration/filter/download scenario usesuser_datato avoid that upstream schema inconsistency.After synchronization with #274: This updated layer passed locked all-feature workspace compilation, diff checks, and all-files pre-commit hooks. The combined stack in #284 passed 1,389 workspace tests, 31 PostgreSQL/pgvector tests, and 17 maintained SDK cases, plus the Rust 1.88 all-feature check and all-target workspace clippy. The pipeline integration review is complete. GitHub CI is rerunning for the updated heads; previous green checks apply to the prior revisions.