368: Use Local File Path annotation

[pgarrison]

Purpose

Render the new "Local File Path" annotation nicely. The goal is to display something like this:

File Path (Vast) /mypath/aics/software/apps/staging/fss/data/7fb/6fb/b0f/6bd/7d5/1db/a4c/1e4/2a6/2a5/c7/aicsfiles-test-a4cb9af6-bcfa-11ef-8fe8-0242ac110002.czi

Closes #368
Closes #369

Changes

• I had to create some logic for renaming the annotation from "Local File Path." I ended up putting it in the HttpAnnotationService, which has a few benefits.
  • The implementation is simpler than putting the logic downstream (e.g., in the FileAnnotationList).
  • The renaming only applies to the FMS data source, so people running BFF from a CSV won't be surprised by it.

Testing

• Fixed and updated existing test for renaming mount points (see FileAnnotationList test asserts nothing and would fail if it did assert #369 for more details)
• New test for renaming in HttpAnnotationService
• Manual test in staging:
  

Notes

• The name File Path (Local) was used before File Path (Vast). I don't have a strong preference: please weigh in. The new FMSAnnotationPresentationLayer makes it easy to change it up.
• I'm not totally sure of the name FMSAnnotationPresentationLayer nor the choice to put this annotation-renaming logic here instead of FES or changing the name in LabKey and the ETL pipeline.

[lynwilhelm]

@pgarrison If we are specifically calling out VAST in the "Copy files to local NAS (VAST)" modal @BrianWhitneyAI was working on, perhaps we should be consistent and mention VAST here? Without potentially understanding the whole picture, I usually think you should be more general in terminology so that if VAST changes to something else someday, we won't have to worry about updates. BUT, I read Kevin M's recent comment somewhere that he was happy to see us calling VAST out specifically, which makes me think users have been confused in the past about what our local storage was called? To be consistent, maybe the label should say (Local VAST) or (Local/VAST)?

[pgarrison]

@pgarrison If we are specifically calling out VAST in the "Copy files to local NAS (VAST)" modal @BrianWhitneyAI was working on, perhaps we should be consistent and mention VAST here? Without potentially understanding the whole picture, I usually think you should be more general in terminology so that if VAST changes to something else someday, we won't have to worry about updates. BUT, I read Kevin M's recent comment somewhere that he was happy to see us calling VAST out specifically, which makes me think users have been confused in the past about what our local storage was called? To be consistent, maybe the label should say (Local VAST) or (Local/VAST)?

@lynwilhelm I realized I uploaded the wrong screenshot -- it's fixed now. The current version of this PR says "File Path (Vast)". Does that seem good to you, or do you think "File Path (Local Vast)" is more clear?

@pgarrison Classic;) IDK, I slightly lean toward calling it local storage too. Whatever you think...but last thing is VAST is an acronym so I think you should do uppercase, right?

[pgarrison]

Lyndsay left the following comment.

@pgarrison Classic;) IDK, I slightly lean toward calling it local storage too. Whatever you think...but last thing is VAST is an acronym so I think you should do uppercase, right?

So I think this PR needs to be updated to "File Path (Local VAST)" before merging.

@BrianWhitneyAI

[pgarrison]

Thanks @BrianWhitneyAI!