(WIP) Implemented proper ROS service behavior and modified Auto Dig and Auto Offload logic #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Refactor swerve drive into tank drive"
…T-Robotics/Lunabotics into Refactor-swerve-into-tank
…T-Robotics/Lunabotics-2024 into Refactor-swerve-into-tank
Co-authored-by: cparece1 <[email protected]>
…T-Robotics/Lunabotics into Refactor-swerve-into-tank
…r asnyc improvements
…code for autodig, and now theres a todo in motor control!
jmblixt3
reviewed
Oct 23, 2024
jmblixt3
reviewed
Oct 29, 2024
jmblixt3
reviewed
Oct 29, 2024
jmblixt3
force-pushed
the
AutoDig-Improvements
branch
from
e2670a8
to
b17b67e
Compare
…dumping via yaml config dig_time and dump_time, set to 5 seconds atm in auto dig and dumper_node - we should probably standardize this
…es of calls from autooffload server)
jmblixt3
reviewed
Nov 22, 2024
Comment on lines
+207
to
+210
| while(abs(this->can_data[id].tachometer - this->pid_controllers[id]->getTargTach()) > this->tachThreshold) | ||
| { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
What do you do if you want to stop the motor before it reaches its final position
jmblixt3
force-pushed
the
AutoDig-Improvements
branch
2 times, most recently
from
ed4f5e8
to
e05dd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.