August 24, 2022

Time/Place

This meeting is held virtually via Zoom, with an open channel for chatter on Slack. Anyone is welcome to join. The hosting can be claimed by anybody with the host ID. The Host ID is in the header of the TAG slack channel.

Time: 1:00pm Eastern Time US (UTC-5)
Zoom link: https://zoom.us/j/97345581392
Passcode: 919241
Join us on the Slack Islandora Channel https://islandora.slack.com/archives/CM5PPAV28

Chair Roster

These are the core members of TAG and will take on chair of the meeting if there are no volunteers, and will support volunteers who are chairing for the first time:

Don 🪑
Seth
Rosie
Willow

Attendees

Don Richards (Chair)
Adam Vessey
Seth Shaw
Jordan Dukart
Rosie Le Faive
Willow Gillingham
Rebel Cumming-Sauls
Cary Gordon
Isabella Nikolaidis (notes)

Agenda

Note that links are to the document repository only. New issues in other repositories or organizations will not appear in this list, and should be added by interested parties directly to the agenda.

Issue Roundup - Link sorted by recently updated
PR Roundup- Link sorted by recently updated
Review of mailing list
Building a Migrations spreadsheet - Isabella
Feel free to add more, or add something from Islandora Discussions

Minutes

Issue Roundup

https://github.com/Islandora/documentation/issues/2154

Michelle and Rosie to collaborate

https://github.com/Islandora/documentation/issues/2129

Adam references a pull request that requires review (in PR roundup), has gone through internal QA at DGI

https://github.com/Islandora/documentation/issues/1580

Willow: Following up on discussion from Islandoracon, didn't see it working for the Islandora Lite, or we might have seen a screenshot?
Willow: Deciding whether we want to take a look at that but we're probably going to have to code it out similar to how it was done in Islandora 7
Willow: requiring Drupal Vision requires a charge per month for API calls
Willow: HOCR should do it, and we think we can come up with a way to make the same sort of manifest annotations based on the HOCR file and use that with Mirador.
API calls are for the OCRing or the highlighting?
Willow: For highlighting, the Drupal Vision API
Jordan: Other projects using this plugin
- https://github.com/dbmdz/mirador-textoverlay
Jordan: The way you're using HOCR shouldn't really matter, but customization is how do you store and reference things in islandora
- ex. building it with plugins you have to buildit up from source
- HOCR can be generated via Abbey, Tesseract, etc
Mirador may need it to serve it up in something that's not OCR, there might be an intermediary form needed
Don: Solr OCR highlighting ?
- https://dbmdz.github.io/solr-ocrhighlighting/0.8.1/
Seth: Drupal is 'opinionated' of how the search solr interaction works
Jordan: In the past, those data streams could be indexed and solr could do full text hits on the results.

PR Roundup

https://github.com/Islandora/documentation/pull/2155

Merged

https://github.com/Islandora/islandora/pull/896

Jordan: Questions to discuss left in a comment on this PR.
- Should the existing upload forms be removed or deprecated? I'd personally lean towards removal but @adam-vessey has left them in for the time being given that it's not clear if other people could have extended/implemented them.
- The implementation within this PR mirrors the existing functionality to provide parity but the original does have some oddities. An example would be allowing any content type (regardless of the presence of a model field) to be added to a collection.
Jordan: Had a client use it as part of islandora core and asked where the files ended up around the same time that Alexander found this issue
- Same functionality that had security vulnerability there
Adam: It was saving things to temporary because apache private temp goes away when you restart the system.
Seth: Bring this up in the open call? Or to the email list? Rather than just on the pr about deprecating functionality and why it's necessary?
Jordan: Functionality isn't going away, but if someone using the classes directly and we were to remove them there could be stuff that breaks, there's more hardening around those things that didn't exist before.
Rosie: How can you deprecate a class? How do you put code somewhere that someone will realize that it's an extension that is gonna go away?
Adam: Unless marked otherwise, classes are considered internal. If we're basing it on Drupal backwards compatibility policy, we remove them.
Rosie: Are we good with considering form classes to be internal and delteing them without going through a deprecation cycle? Is this something that we might need more alert to the community? ex. if you were using these classes, update your code
Jordan: Lacking a drupal equivalent of change records.
Don: What if we leave the class there but add the warning as you're using the module you get watchdog errors, this is going to be deprecated in the next release
- https://www.drupal.org/about/core/policies/core-change-policies/drupal-deprecation-policy
Adam: https://www.drupal.org/about/core/policies/core-change-policies/bc-policy#controllers - where it indicates that it's not necessary to have a deprecation cycle.
Jordan: Keep them for a time , or pull them away and make sure it's very clear in the release notes or issue.
Adam: Also, it should be easy for someone to pull the classes out into their own code
Rosie: For documentation - do the buttons look the same?
Adam: The buttons are the same, form slightly different
Adam: Gets into how you have your widgets configured for the particular type of media you've selected.
Adam: https://www.drupal.org/docs/creating-modules/let-drupal-know-about-your-module-with-an-infoyml-file

https://github.com/Islandora/jsonld/pull/68

Seth: You need to able to run the PHP CLI, because you have to make an invalid value to test it

https://github.com/Islandora/controlled_access_terms/pull/82

Rosie: Requires that you have the version one with the security update.
On a failed build, so Rosie will rebase
Adam: Could this be possiby going further than version?
Rosie: What would be a good policy for bumping dependencies?
Seth: As long as there's not a conflict with the other module it's probably fine
Rosie: Are we good with an OR for these versions or should we just jump up to 3?
Adam: Tempted to put it as an OR becauset here might be something else constraining it still somewhere
Rosie: I'll implement an OR.

Other

https://www.drupal.org/project/rest_oai_pmh/issues/3304554

Jordan: Outlines how limit/offset chunking can give duplicate results, for example if you have the same epoch for your created date.
Rosie: So is the problem you can have a view without an order?
Jordan: Issue open is a database scrape behind the scenes
- This can also pop up if you were writing any view, and have same day created you can get weird results with chunking and offsetting

Migrations spreadsheet