-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruTorrent v5.1 - Beta (Please reply here for feedback) #2721
Comments
Can we preserve the sticky feature of the legend text, that sticks to the viewport until the cobtaining box is scrolled completely outside the viewport? I like this one, as it's cool and helpful for long fieldsets blocks. We can define the background color of the legend text to prevent the overlapping. |
I think that is a great idea, as long as we're able to clean it up properly. Can we still keep the elements inside the div group (with the legend) while we scroll? |
Yes, we can have the elements inside the group. We just add a non-transparent background to the legend text to cover the elements underneath to prevent overlapping. I've created a new pull request here (with a screenshot inside): |
What would you like changed about the web client?1: On mobile, the side menu accessed by the "..." button takes up the entire width of the viewport, resulting in there being no room beside the menu to touch and close out of it. If I switch my phone to landscape mode and then back to portrait mode again, the menu width is correct (the same as on my PC). Refreshing the page after switching orientation results in the menu again expanding to the full viewport width. 2: Another minor thing is the tabs in the lower torrent info section (General, Files, Trackers, etc.). When I press a tab, it slowly expands the tab bar vertically and pushes down the content of the tab below. It also results in the tab quickly snapping up and then sagging down again every time I press a different tab. Describe the solution you'd like and propose possible alternatives.1: Probably needs a CSS fix to force the menu not to expand all the way, or perhaps a way to properly detect the media width on first load? Otherwise, a button could be added to the left of the "ruTorrent v5.B.1" label to close the side menu. Another option would be to shift the vertical position of the side menu down so as not to cover the button on the main page. 2: I think the tab pop-out behaviour would be okay if it were faster and if the tab bar had a fixed height; however, I personally would prefer no transition at all, since the content of the tab loads immediately without transition anyway. Provide information and resources about the environment hosting the web clientOS: Raspberry Pi OS (Debian Bookworm)
Thank you for all the effort on this UI rewrite. It's looking great so far :) |
Hi, @Airman8 , thank you for testing and the all feedback!
There is a close button on the top-right corner of the panel. I realize that it might not be easy enough to spot, especially in dark themes. We'll adjust the color schemes if that's the problem. As for the side panel width, the current version won't set the width of the side panel for mobile screens (< 768px), so it would take the default value of the Bootstrap framework. We can adjust the process to set the width of the side panel for any screen size.
I didn't see the slow transition on the tab list and the tab detail page. Have you tried disabling the "iPad" plugin? This plugin simulates mouse events on touch events, and causes strange behaviors. It's going to be remove in the final stable release. For now, just disabling it should be fine. |
@Airman8 Thank you for your feedback. We have addressed it and tagged ruTorrent v5.0-Beta-2 with 10 bug fixes. Would you like to test it (with the ipad plugin deleted) and let us know what you think? |
@stickz Sure, I installed v5.0-beta2 and have been looking at all the themes.
@jevenski I realize I had neglected to mention that I was using the MaterialDesign theme. I edited my comment for brevity and accidentally cut that part out - my apologies. I turned up the brightness on my phone and did see the button.
I checked that the ipad plugin was disabled in my previous installation, and it has been removed in v5.0-beta2 as well. For v5.0-beta2, I tried all the other themes on both desktop and mobile. I noticed that this particular issue with the tab bar growing downward is only happening with the MaterialDesign theme. I also found that clicking on certain tabs in all the other themes causes the whole bottom section to grow vertically by 1 or 2 pixels. The tabs that do this the most often are the history and plugins tabs, but it happens with others depending on the theme. (Incidentally, this doesn't happen in the MaterialDesign theme.) I thought that it might be caused by the content of the active tab having x-overflow content, which could cause the scrollbar to appear and maybe bump the tab upward. But it happens even if I make the various fields in each tab narrower so that everything fits on the screen, so I'm not sure what's really making it happen. This isn't a big usability issue or anything. It's just a quirky UI thing where I can see the tab bar moving slightly up and down as I click through the tabs. As for the X button in the side menu, it does look like just a matter of dark themes vs light themes. The X is always black, so it doesn't show up well in dark themes. Is it possible to get the colour of the X to match the colour of the other menu buttons? (for example, grey in the dark theme and blue in the MaterialDesign theme) In the "DarkBetter" theme, the triangle icon on the side menu which indicates whether sections are visible or folded gets bigger for folded sections. This does not happen in the "Dark" theme though. I was messing around in the right-click shortcut menu to see how it felt to navigate, and I accidentally removed a torrent because I touched "remove" when I meant to press "set channel". This could be a fatal "off-by-one error" if someone were to accidentally remove a whole label or tracker worth of torrents. In case anyone else has fat fingers like me, would it be possible to increase the vertical padding of the menu items on the mobile layout? Looking forward to the full release! |
|
Hi, @Airman8 , I adjusted the resize function of side panel to skip resizing on mobile, Now the side panel should always be of default width of Bootstrap's offcanvas panel. Hi, @koblack , here's some fixes according to your feedback. The others were probably introduced by some earlier commits, and I'm still on the way of getting familiar with them, and not 100% sure how to fix them properly. Perhaps someone can fix those before I figure out how those features work.
These three bugs were fixed.
Options were added to the General UI settings to allow setting the min width of the side panel and the min height of the list table. You can set the values as per your need. Related PR: #2723 |
These minor issues are less urgent than the other issues below, but could take longer time to diagnose, so I think we can let them go now and come back to them after the stable release and fix them in v5.1.
It's very likely that the X button wasn't adapted to different themes when first introduced. I can look into this one.
This could be related to the image files themselves that are being used as the background images. I can look into this one, too.
I'm thinking about increasing the font size of the entire page to 16px on mobile, as it's the recommended font size for mobile apps. That would also reduce the likability of those fatal off-by-one errors happening (I made an exactly same error of deleting a torrent myself.) This change, however, requires more fine tuning as it affects the entire page, so more tests need to be done before I push this one. |
What would you like changed about the web client?Removing the iPad plugin did leave a side-effect on iOS devices. A major regression is that the Describe the solution you'd like and propose possible alternatives.I'm thinking about defining a custom event for iOS devices to respond to long pressing actions and bring up the context menus. Provide information and resources about the environment hosting the web client.Server: ruTorrent v5.0-Beta 2 on Ubuntu 22.04 LTS Additional contextNone. |
@Airman8 @koblack @jevenski Thanks so much for your help! You've helped us eliminate 20 bugs before posting a stable release of ruTorrent! We've addressed your feedback! I've posted one final beta version of v5.0. Could you give it a try and give your thoughts about posting a stable version of ruTorrent? https://github.com/Novik/ruTorrent/releases/tag/v5.0-beta3 @jevenski and I would like to get started on |
I looked at the themes again in v5.0-beta3 Side menu width is now consistent when I rotate to landscape orientation and then back to portrait again. On my Galaxy S9 the menu fills (edit: almost) the whole viewport width, but I can navigate away with the X button so no worries. Another very minor thing, maybe for a later version: The background colour of the X button seems to be getting affected by the backdrop fader while the side menu is open, so it looks darkened in the same way as the inactive buttons. In the Oblivion theme it's a bit low contrast, but it's still visible enough. |
|
Great job testing everyone! Keep up the good work! We are getting very close to tagging the stable |
Originally posted by @koblack in #2748 (comment) Screenshots on mobile has overflow flaws. Submitting a PR to address this issue: #2773 |
@koblack @jevenski @castillo92 I've posted ruTorrent v5.1-beta4. Your help testing would be greatly appreciated. I've decided to delay ruTorrent v5.1 stable by 1 week to test more. https://github.com/Novik/ruTorrent/releases/tag/v5.1-beta4 |
I can't vertically scroll the RSS Manager on mobile, so everything below the heading "RatioGroup" is invisible. This includes the RatioGroup selection box, the Channel heading and selection box, as well as the Reset, OK, and Cancel buttons. Very minor UI thing I also noticed with the left menu. The X button is shaded to look like it's in the background even though it's in the foreground. Other than that, I haven't noticed any major issues. |
Hi! Love this feedback thread, and love the 5.1 beta. Some enhancements that would go a long way for me on mobile: (Safari, iPhone 14 Pro)
Thank you! |
Submitting a PR for this one: #2778. It was previously planned for v5.2, but now it seems more urgent that we'd better include this in v5.1 stable. |
@Airman8 Thanks so much for reporting this issue! We've now resolved it! Could you confirm a successful resolution by trying the latest master zip file? https://github.com/Novik/ruTorrent/archive/refs/heads/master.zip |
Thanks for the feedback @adapowers. Could you try downloading the Google Chrome application on your iPhone 14 Pro and report back how much easier it is to operate ruTorrent? Safari has known item selection issues, which can't be addressed in Also, we plan to make more improvements like font and row sizing in |
Hello @stickz In general, I didn't found important issues in iOS 18.1, only this two litte things, for me low priority and importance:
5.1b4.mp4
5.1b4_2.mp4 |
@stickz We're closer to resolution, but there's one remaining issue. The content of the dialogue box scrolls properly, but the position of the three buttons is fixed and partially hidden behind the soft keys of my phone's UI. Phone is a Samsung Galaxy S9 running LineageOS (old and completely lacking a back plate, but still hanging on). This is as much as I can see of the buttons: |
I am now running 5.1.B4 and I've noticed that the diskspace graphic and the port status indicater images do not load. I did recently switch from single user to multi user though. Any pointers as to where I might start to look? I cleared my browsers cache but to no avail. AFAIK, Apache isn't caching anything. Edit: this is when connecting over http. The https version works fine. Strange! |
Lines 149 to 150 in a1c7969
I'm thinking the dynamic viewport height could be the culprit. The dialog window now takes 95% of viewport height which is what the |
This fix worked for me as well, with the same results as @koblack had. I tested the other windows as well, and nothing changed from before, so they all work still too.
@jevenski |
We've released Beta 5 to address everyone's feedback! Are we ready now for the stable release? |
The issue with the RSS downloader remains resolved in Beta 5, and I've found no other issues so far. |
Hello Stickz, testing 5.1B5. At first sight, no bugs. But I ask you a question... I allways make an update of ruTorrent, I lost the list of limits od DL an UP Speeds. Where is stored to make it backupeable? This is my procedure to update ruTorrent.
|
* Updated ruTorrent to revision v5.1-beta5 Novik/ruTorrent#2721 * Documentation updated
User settings and uploaded torrent files (if set to be saved) are stored in |
I found very interesting bug and I dont even understand how is this possible. Now I have 2 folders named NEW MOVIES. I did not think i even could greate 2 folders with exactly the same name. I am so confused. Now old movies are in old folder and new movies are in new folder. |
What would you like changed about the web client?
I would like the legend not to overlap with text when scrolling on mobile.
Describe the solution you'd like and propose possible alternatives.
Implementing appropriate CSS style changes to avoid the undesired behavior.
Provide information and resources about the environment hosting the web client.
Server: ruTorrent v5.0-Beta 1 on Ubuntu 24.04 LTS
Web Client: Google Chrome 129.0.6668.59
Installation Method: zip source from version release
Additional context
I believe @jevenski is able to resolve this problem. Here is a screenshot to provide additional context.
The text was updated successfully, but these errors were encountered: