Skip to content

mqtt: test mqtt frames v2#1065

Closed
hsadia538 wants to merge 1 commit intoOISF:masterfrom
hsadia538:mqtt-frames-v2
Closed

mqtt: test mqtt frames v2#1065
hsadia538 wants to merge 1 commit intoOISF:masterfrom
hsadia538:mqtt-frames-v2

Conversation

@hsadia538
Copy link
Contributor

@hsadia538 hsadia538 commented Jan 16, 2023

Ticket: https://redmine.openinfosecfoundation.org/issues/5731

Previous PR: #1064

Describe changes:

  • Add tests for mqtt frames

Requires: OISF/suricata#8382

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Jan 18, 2023
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this first set of frame types, this is looking good, to me :)

@jufajardini jufajardini added the requires suricata pr Depends on a PR in Suricata label Jan 18, 2023
@jufajardini
Copy link
Contributor

In light of the last discussions around truncated messages, I think it would be good to have a test with frames and those truncated types, so we could see what are the frames registering in such a case. :)

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see my comment :)

@hsadia538
Copy link
Contributor Author

In light of the last discussions around truncated messages, I think it would be good to have a test with frames and those truncated types, so we could see what are the frames registering in such a case. :)

Ok I will incorporate this in a new SV PR and then you will re-run CI checks for this one?

@jufajardini
Copy link
Contributor

In light of the last discussions around truncated messages, I think it would be good to have a test with frames and those truncated types, so we could see what are the frames registering in such a case. :)

Ok I will incorporate this in a new SV PR and then you will re-run CI checks for this one?

I think that can work. If not, we'd need a new Suricata PR.

@hsadia538 hsadia538 mentioned this pull request Feb 3, 2023
@hsadia538
Copy link
Contributor Author

Followed by #1112

@hsadia538 hsadia538 closed this Feb 3, 2023
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Oct 31, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Nov 7, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Nov 22, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 11, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 12, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 13, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 16, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 17, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 17, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 23, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 23, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Dec 27, 2024
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 8, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 8, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 8, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 11, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 11, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 13, 2025
AkakiAlice added a commit to AkakiAlice/suricata-verify that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outreachy Contributions made by Outreachy applicants requires suricata pr Depends on a PR in Suricata

Development

Successfully merging this pull request may close these issues.

2 participants