gtest cmake: fix unit test filter #23978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Unit test filtering doesn't work anymore on main since https://github.com/PX4/PX4-Autopilot/pull/23869/files#r1841024972
Solution
Seems that apparently the parameters cannot be assembled in a CMake string variable like that so I'll just explicitly add the
-r
argument in the separate already existingTESTFILTERARG
variable.Changelog Entry
Test coverage
Works again like expected on 22.04. @mrpollo please check if it makes the error you described in https://github.com/PX4/PX4-Autopilot/pull/23869/files#r1841089807 reappear. I couldn't guess where you had it but it should still be fixed.