Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest cmake: fix unit test filter #23978

Merged
merged 1 commit into from
Nov 20, 2024
Merged

gtest cmake: fix unit test filter #23978

merged 1 commit into from
Nov 20, 2024

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Nov 19, 2024

Solved Problem

Unit test filtering doesn't work anymore on main since https://github.com/PX4/PX4-Autopilot/pull/23869/files#r1841024972

Solution

Seems that apparently the parameters cannot be assembled in a CMake string variable like that so I'll just explicitly add the -r argument in the separate already existing TESTFILTERARG variable.

Changelog Entry

Fix: Unit test filter

Test coverage

Works again like expected on 22.04. @mrpollo please check if it makes the error you described in https://github.com/PX4/PX4-Autopilot/pull/23869/files#r1841089807 reappear. I couldn't guess where you had it but it should still be fixed.

@MaEtUgR MaEtUgR added bug Tools Sub-tools used within PX4 ecosystem (scripts, etc) labels Nov 19, 2024
@MaEtUgR MaEtUgR requested a review from mrpollo November 19, 2024 19:38
@MaEtUgR MaEtUgR self-assigned this Nov 19, 2024
Copy link

FLASH Analysis

px4_fmu-v5x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

px4_fmu-v6x
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    .text
  -0.0%      -8  [ = ]       0    [Unmapped]
  [ = ]       0  +0.0%      +8    TOTAL

@dagar dagar merged commit 1aadbf8 into main Nov 20, 2024
37 of 41 checks passed
@dagar dagar deleted the maetugr/fix-unit-test-filter branch November 20, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Tools Sub-tools used within PX4 ecosystem (scripts, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants