Honda - set belowEngageSpeed for Nidec Hybrid brakehold #36121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
Let me know if anything beyond commenting is needed to get this out of "stale" state. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
kmk142789
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honda Nidec Hybrids fault when enabling cruise directly from brake hold. Driver needs to disengage brakehold with gas first.
This problem newly occurred due to the change in #34384
This PR prevents engagement and pops up a message for the driver to increase speed. It seemed to be the most appropriate of the available NO_ENTRY alert types.
Dependent on commaai/opendbc#2671
Testroute: ad9840558640c31d/00000002--531e9d28b4