-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/provide-alias-path-on-extra-mounts-in-model-service #2448
Draft
lizable
wants to merge
2
commits into
main
Choose a base branch
from
05-30-feature_provide-alias-path-on-extra-mounts-in-model-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feature/provide-alias-path-on-extra-mounts-in-model-service #2448
lizable
wants to merge
2
commits into
main
from
05-30-feature_provide-alias-path-on-extra-mounts-in-model-service
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This was referenced May 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
21de62e
to
e647c36
Compare
Base automatically changed from
feature/refactor-model-storage-mount-in-model-service-launcher
to
main
May 31, 2024 06:52
e647c36
to
ae82022
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.82% | 140/4965 |
🔴 | Branches | 3.01% | 101/3360 |
🔴 | Functions | 1.66% | 27/1631 |
🔴 | Lines | 2.69% | 131/4875 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 5f127ab
ae82022
to
be54b59
Compare
a3ad461
to
c126de8
Compare
## TL;DR This PR adds a 'Sync Routes' button to the EndpointDetailPage in the React application. This button allows users to initiate synchronization of routes for a specific endpoint.  ## What changed? - Added a 'Sync Routes' button with associated icons and loading state. - Created a mutation to handle the route synchronization logic. - Updated language files to include translations for the new 'Sync Routes' feature. ## How to test? 1. Navigate to the EndpointDetailPage. 2. Verify that the 'Sync Routes' button is present next to the RoutesInfo section. 3. Click the 'Sync Routes' button and observe the success or failure message. ## Why make this change? This change enhances the usability of the EndpointDetailPage by providing an easy way to synchronize routes directly from the UI. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
c126de8
to
5f127ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)