Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/provide-alias-path-on-extra-mounts-in-model-service #2448

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lizable
Copy link
Contributor

@lizable lizable commented May 30, 2024

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

lizable commented May 30, 2024

@lizable lizable force-pushed the 05-30-feature_provide-alias-path-on-extra-mounts-in-model-service branch from 21de62e to e647c36 Compare May 30, 2024 09:32
Base automatically changed from feature/refactor-model-storage-mount-in-model-service-launcher to main May 31, 2024 06:52
@lizable lizable force-pushed the 05-30-feature_provide-alias-path-on-extra-mounts-in-model-service branch from e647c36 to ae82022 Compare June 3, 2024 02:10
Copy link

github-actions bot commented Jun 3, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 2.82% 140/4965
🔴 Branches 3.01% 101/3360
🔴 Functions 1.66% 27/1631
🔴 Lines 2.69% 131/4875

Test suite run success

51 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 5f127ab

@lizable lizable force-pushed the 05-30-feature_provide-alias-path-on-extra-mounts-in-model-service branch from ae82022 to be54b59 Compare June 5, 2024 02:14
@lizable lizable force-pushed the 05-30-feature_provide-alias-path-on-extra-mounts-in-model-service branch 2 times, most recently from a3ad461 to c126de8 Compare June 13, 2024 06:46
yomybaby and others added 2 commits June 19, 2024 14:11
## TL;DR

This PR adds a 'Sync Routes' button to the EndpointDetailPage in the React application. This button allows users to initiate synchronization of routes for a specific endpoint.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/6d9658de-e754-4068-affb-9db806bba6ab.png)


## What changed?

- Added a 'Sync Routes' button with associated icons and loading state.
- Created a mutation to handle the route synchronization logic.
- Updated language files to include translations for the new 'Sync Routes' feature.

## How to test?

1. Navigate to the EndpointDetailPage.
2. Verify that the 'Sync Routes' button is present next to the RoutesInfo section.
3. Click the 'Sync Routes' button and observe the success or failure message.

## Why make this change?

This change enhances the usability of the EndpointDetailPage by providing an easy way to synchronize routes directly from the UI.

---

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@lizable lizable force-pushed the 05-30-feature_provide-alias-path-on-extra-mounts-in-model-service branch from c126de8 to 5f127ab Compare June 19, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants