feat(mapgen-studio): saved-config precedence — drift detection + orange Modified affordance with click-to-resync#1660
Merged
Conversation
This was referenced Jun 12, 2026
Merged
Owner
Author
This was referenced Jun 12, 2026
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/y1-run-proof-request-id
to
graphite-base/1660
June 12, 2026 22:52
…ge Modified affordance with click-to-resync The game-setup dropdowns must never silently supersede a selected saved config. Verified the suspected partial-overwrite is NOT real (dropdown changes merge cleanly into setupConfig); the real gap was silent drift with the selector still presenting the file as authoritative. Categorical rule (same vocabulary as the world/map Modified state): drift = 're-applying the saved file would change the state' (studioSetupDriftsFromSavedConfig — the file governs the setup options it specifies plus its player options; ungoverned keys are deliberately kept by the apply-merge and never count). The header selector gains a warning ring + an orange Modified pill; clicking the pill re-applies the saved config (sync back is a no-op exactly when clean). 5 new drift pins in setupConfig.test.ts. Verified live: Speed → Quick raised the ring + pill (and the run chip correctly flipped Stale); pill click restored Standard and cleared both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/y2-saved-config-precedence
branch
from
June 12, 2026 22:54
9265fec to
55582ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game-setup dropdowns must never silently supersede a selected saved
config. Verified the suspected partial-overwrite is NOT real (dropdown
changes merge cleanly into setupConfig); the real gap was silent drift
with the selector still presenting the file as authoritative.
Categorical rule (same vocabulary as the world/map Modified state): drift
= 're-applying the saved file would change the state'
(studioSetupDriftsFromSavedConfig — the file governs the setup options it
specifies plus its player options; ungoverned keys are deliberately kept
by the apply-merge and never count). The header selector gains a warning
ring + an orange Modified pill; clicking the pill re-applies the saved
config (sync back is a no-op exactly when clean).
5 new drift pins in setupConfig.test.ts. Verified live: Speed → Quick
raised the ring + pill (and the run chip correctly flipped Stale); pill
click restored Standard and cleared both.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com