docs(mapgen-studio): JSDoc the load-bearing seams + honest-boundary notes#1668
Merged
Conversation
This was referenced Jun 12, 2026
Merged
Owner
Author
This was referenced Jun 12, 2026
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/p7-explore-wiring
to
graphite-base/1668
June 12, 2026 23:08
…otes P7 idiom wave: engine-contract JSDoc (StudioEngines, the Run-in-Game orchestrator incl. the materialization-proof correctness boundary), the authored-setup-state contract on Civ7StudioSetupConfig, documented deliberate-opacity casts at the oRPC read seam (+ observedAt fallback parity), and a stale Game-bar comment fix. Deliberately NOT folding the per-feature oRPC error envelopes into one helper (distinct shapes; native oRPC error-handling refactor tracked separately).
mateicanavra
force-pushed
the
design/p7-idiom-jsdoc-polish
branch
from
June 12, 2026 23:10
8d04935 to
3ac0f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

P7 idiom wave: engine-contract JSDoc (StudioEngines, the Run-in-Game
orchestrator incl. the materialization-proof correctness boundary), the
authored-setup-state contract on Civ7StudioSetupConfig, documented
deliberate-opacity casts at the oRPC read seam (+ observedAt fallback
parity), and a stale Game-bar comment fix. Deliberately NOT folding the
per-feature oRPC error envelopes into one helper (distinct shapes; native
oRPC error-handling refactor tracked separately).