fix(mapgen-studio): saved config launches exactly — selection replaces studio setup state, any drift shows Custom#1665
Merged
Conversation
This was referenced Jun 12, 2026
Merged
Owner
Author
This was referenced Jun 12, 2026
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/post-main-restack-reconcile
to
graphite-base/1665
June 12, 2026 23:02
…s studio setup state, any drift shows Custom Config-precedence repair (P7 review): at launch the engine loads the saved config file into Civ7 and then re-applies every studio game/player option on top, so selection-by-merge let stale studio keys silently override the file. Selection now applies the file exactly (studioSetupConfigFromSavedConfigFile, previously production-dead), drift counts ANY difference from the file-derived state, and the drifted selector shows Custom with a Re-apply affordance. updateStudioSetupSavedConfig (the merge) is removed.
mateicanavra
force-pushed
the
design/p7-config-precedence-custom
branch
from
June 12, 2026 23:04
78f8a81 to
77168b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config-precedence repair (P7 review): at launch the engine loads the saved
config file into Civ7 and then re-applies every studio game/player option on
top, so selection-by-merge let stale studio keys silently override the file.
Selection now applies the file exactly (studioSetupConfigFromSavedConfigFile,
previously production-dead), drift counts ANY difference from the
file-derived state, and the drifted selector shows Custom with a Re-apply
affordance. updateStudioSetupSavedConfig (the merge) is removed.