Skip to content

[BugFix] Defer filter_warnings import to avoid module load issues #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[BugFix] Defer filter_warnings import to avoid module load issues #3270

vmoens merged 2 commits into from
Dec 31, 2025
+7 −1

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
f0d3546 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3270

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@vmoens
Update
df03691 
[ghstack-poisoned]
This was referenced Dec 31, 2025
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[BugFix] Defer filter_warnings import to avoid module load issues
8ea954c 
ghstack-source-id: e9e86d9
Pull-Request: #3270
@vmoens vmoens merged commit df03691 into gh/vmoens/170/base Dec 31, 2025
78 of 93 checks passed
@vmoens vmoens deleted the gh/vmoens/170/head branch December 31, 2025 09:17
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}12$. Worsened: $\large\color{#d91a1a}10$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 85.8343μs 84.5087μs 11.8331 KOps/s 12.4289 KOps/s $\color{#d91a1a}-4.79\%$
test_tensor_to_bytestream_speed[torch.save] 0.1439ms 0.1431ms 6.9886 KOps/s 7.1557 KOps/s $\color{#d91a1a}-2.34\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1109s 0.1107s 9.0312 Ops/s 8.9146 Ops/s $\color{#35bf28}+1.31\%$
test_tensor_to_bytestream_speed[numpy] 2.6132μs 2.6041μs 384.0061 KOps/s 379.4162 KOps/s $\color{#35bf28}+1.21\%$
test_tensor_to_bytestream_speed[safetensors] 40.3189μs 39.9878μs 25.0076 KOps/s 26.5209 KOps/s $\textbf{\color{#d91a1a}-5.71\%}$
test_simple 0.5491s 0.5469s 1.8283 Ops/s 1.7587 Ops/s $\color{#35bf28}+3.96\%$
test_transformed 1.1321s 1.1287s 0.8860 Ops/s 0.8821 Ops/s $\color{#35bf28}+0.44\%$
test_serial 1.6665s 1.6531s 0.6049 Ops/s 0.6000 Ops/s $\color{#35bf28}+0.82\%$
test_parallel 1.2504s 1.1580s 0.8636 Ops/s 0.9074 Ops/s $\color{#d91a1a}-4.83\%$
test_step_mdp_speed[True-True-True-True-True] 0.2778ms 45.9638μs 21.7562 KOps/s 22.8206 KOps/s $\color{#d91a1a}-4.66\%$
test_step_mdp_speed[True-True-True-True-False] 60.3340μs 25.3353μs 39.4706 KOps/s 39.8583 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-True-False-True] 60.4140μs 24.6984μs 40.4884 KOps/s 39.6792 KOps/s $\color{#35bf28}+2.04\%$
test_step_mdp_speed[True-True-True-False-False] 48.8130μs 13.7669μs 72.6382 KOps/s 72.1854 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[True-True-False-True-True] 0.1042ms 47.4165μs 21.0897 KOps/s 21.0705 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-True-False] 59.7940μs 27.7564μs 36.0277 KOps/s 36.4148 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-True-False-False-True] 67.9540μs 27.8617μs 35.8916 KOps/s 35.7543 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-True-False-False-False] 62.3540μs 16.4320μs 60.8568 KOps/s 59.8631 KOps/s $\color{#35bf28}+1.66\%$
test_step_mdp_speed[True-False-True-True-True] 88.6850μs 51.2513μs 19.5117 KOps/s 19.6997 KOps/s $\color{#d91a1a}-0.95\%$
test_step_mdp_speed[True-False-True-True-False] 67.9250μs 30.7278μs 32.5438 KOps/s 32.9069 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[True-False-True-False-True] 57.0140μs 27.6828μs 36.1235 KOps/s 36.2195 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-False-True-False-False] 0.1176ms 16.0314μs 62.3774 KOps/s 59.5105 KOps/s $\color{#35bf28}+4.82\%$
test_step_mdp_speed[True-False-False-True-True] 0.1168ms 52.5951μs 19.0132 KOps/s 19.0711 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[True-False-False-True-False] 61.0140μs 32.8109μs 30.4777 KOps/s 30.3038 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[True-False-False-False-True] 59.3240μs 29.8021μs 33.5547 KOps/s 33.1638 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[True-False-False-False-False] 80.2460μs 19.2575μs 51.9279 KOps/s 51.7370 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[False-True-True-True-True] 0.1242ms 50.1757μs 19.9299 KOps/s 19.9563 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-True-True-True-False] 58.2140μs 30.2887μs 33.0156 KOps/s 32.6605 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[False-True-True-False-True] 2.4033ms 31.7493μs 31.4968 KOps/s 31.6412 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[False-True-True-False-False] 57.9740μs 18.1029μs 55.2397 KOps/s 54.1407 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-True-False-True-True] 90.4060μs 52.4531μs 19.0647 KOps/s 19.0694 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[False-True-False-True-False] 64.6840μs 32.9691μs 30.3315 KOps/s 30.2282 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-True-False-False-True] 85.7060μs 33.7056μs 29.6687 KOps/s 29.2393 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[False-True-False-False-False] 60.1640μs 20.7222μs 48.2573 KOps/s 47.5513 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[False-False-True-True-True] 88.2660μs 55.5495μs 18.0020 KOps/s 18.2268 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-False-True-True-False] 64.2440μs 36.4520μs 27.4334 KOps/s 28.0627 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[False-False-True-False-True] 79.9550μs 33.9338μs 29.4692 KOps/s 30.0515 KOps/s $\color{#d91a1a}-1.94\%$
test_step_mdp_speed[False-False-True-False-False] 51.2840μs 20.8386μs 47.9879 KOps/s 48.4748 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-False-False-True-True] 0.1050ms 57.3864μs 17.4257 KOps/s 17.5372 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[False-False-False-True-False] 77.9650μs 38.0386μs 26.2891 KOps/s 26.0690 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[False-False-False-False-True] 91.4560μs 36.3374μs 27.5199 KOps/s 28.2342 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[False-False-False-False-False] 74.0950μs 23.1798μs 43.1410 KOps/s 42.6582 KOps/s $\color{#35bf28}+1.13\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8790s 0.7776s 1.2861 Ops/s 1.2973 Ops/s $\color{#d91a1a}-0.87\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7524s 0.6419s 1.5578 Ops/s 1.5622 Ops/s $\color{#d91a1a}-0.28\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7904s 1.7056s 0.5863 Ops/s 0.5926 Ops/s $\color{#d91a1a}-1.06\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5599s 1.4812s 0.6751 Ops/s 0.6840 Ops/s $\color{#d91a1a}-1.30\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0148s 1.9310s 0.5179 Ops/s 0.5185 Ops/s $\color{#d91a1a}-0.12\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7880s 1.7035s 0.5870 Ops/s 0.5843 Ops/s $\color{#35bf28}+0.47\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.7527s 4.6618s 0.2145 Ops/s 0.2136 Ops/s $\color{#35bf28}+0.44\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.6290s 4.4882s 0.2228 Ops/s 0.2233 Ops/s $\color{#d91a1a}-0.23\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0852s 2.0005s 0.4999 Ops/s 0.5079 Ops/s $\color{#d91a1a}-1.58\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7728s 1.6789s 0.5956 Ops/s 0.5993 Ops/s $\color{#d91a1a}-0.62\%$
test_values[generalized_advantage_estimate-True-True] 10.7393ms 10.2864ms 97.2153 Ops/s 102.0665 Ops/s $\color{#d91a1a}-4.75\%$
test_values[vec_generalized_advantage_estimate-True-True] 15.9372ms 11.5394ms 86.6600 Ops/s 86.1179 Ops/s $\color{#35bf28}+0.63\%$
test_values[td0_return_estimate-False-False] 0.2425ms 0.1278ms 7.8227 KOps/s 7.8775 KOps/s $\color{#d91a1a}-0.70\%$
test_values[td1_return_estimate-False-False] 28.6192ms 27.2691ms 36.6716 Ops/s 38.1444 Ops/s $\color{#d91a1a}-3.86\%$
test_values[vec_td1_return_estimate-False-False] 12.6418ms 11.5422ms 86.6389 Ops/s 87.5420 Ops/s $\color{#d91a1a}-1.03\%$
test_values[td_lambda_return_estimate-True-False] 41.2588ms 39.2223ms 25.4957 Ops/s 26.0557 Ops/s $\color{#d91a1a}-2.15\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.3801ms 11.8660ms 84.2746 Ops/s 87.6223 Ops/s $\color{#d91a1a}-3.82\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.9059ms 8.8241ms 113.3262 Ops/s 116.5073 Ops/s $\color{#d91a1a}-2.73\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7314ms 1.5311ms 653.1123 Ops/s 650.9783 Ops/s $\color{#35bf28}+0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4743ms 0.4114ms 2.4310 KOps/s 2.4444 KOps/s $\color{#d91a1a}-0.55\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.5225ms 30.9454ms 32.3149 Ops/s 38.9955 Ops/s $\textbf{\color{#d91a1a}-17.13\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.2112ms 1.8137ms 551.3447 Ops/s 540.3875 Ops/s $\color{#35bf28}+2.03\%$
test_dqn_speed[False-None] 1.6024ms 1.3926ms 718.0764 Ops/s 726.1343 Ops/s $\color{#d91a1a}-1.11\%$
test_dqn_speed[False-backward] 1.9238ms 1.8820ms 531.3593 Ops/s 535.9225 Ops/s $\color{#d91a1a}-0.85\%$
test_dqn_speed[True-None] 0.6855ms 0.5357ms 1.8668 KOps/s 1.8847 KOps/s $\color{#d91a1a}-0.95\%$
test_dqn_speed[True-backward] 1.1839ms 1.0864ms 920.5084 Ops/s 864.7854 Ops/s $\textbf{\color{#35bf28}+6.44\%}$
test_dqn_speed[reduce-overhead-None] 0.6559ms 0.5273ms 1.8964 KOps/s 1.8255 KOps/s $\color{#35bf28}+3.89\%$
test_dqn_speed[reduce-overhead-backward] 0.9896ms 0.9580ms 1.0439 KOps/s 873.1342 Ops/s $\textbf{\color{#35bf28}+19.55\%}$
test_ddpg_speed[False-None] 3.2167ms 2.8308ms 353.2562 Ops/s 353.7819 Ops/s $\color{#d91a1a}-0.15\%$
test_ddpg_speed[False-backward] 4.1342ms 4.0146ms 249.0899 Ops/s 250.3690 Ops/s $\color{#d91a1a}-0.51\%$
test_ddpg_speed[True-None] 1.5702ms 1.3864ms 721.2734 Ops/s 724.7588 Ops/s $\color{#d91a1a}-0.48\%$
test_ddpg_speed[True-backward] 2.5350ms 2.3732ms 421.3720 Ops/s 402.5309 Ops/s $\color{#35bf28}+4.68\%$
test_ddpg_speed[reduce-overhead-None] 1.4873ms 1.3782ms 725.6071 Ops/s 721.9396 Ops/s $\color{#35bf28}+0.51\%$
test_ddpg_speed[reduce-overhead-backward] 2.3947ms 2.3358ms 428.1243 Ops/s 375.7464 Ops/s $\textbf{\color{#35bf28}+13.94\%}$
test_sac_speed[False-None] 8.2078ms 7.7506ms 129.0227 Ops/s 127.0294 Ops/s $\color{#35bf28}+1.57\%$
test_sac_speed[False-backward] 11.3104ms 10.9632ms 91.2145 Ops/s 91.2551 Ops/s $\color{#d91a1a}-0.04\%$
test_sac_speed[True-None] 2.3965ms 2.1380ms 467.7181 Ops/s 456.5202 Ops/s $\color{#35bf28}+2.45\%$
test_sac_speed[True-backward] 4.1462ms 4.0027ms 249.8319 Ops/s 218.7042 Ops/s $\textbf{\color{#35bf28}+14.23\%}$
test_sac_speed[reduce-overhead-None] 2.2479ms 2.1166ms 472.4452 Ops/s 465.9174 Ops/s $\color{#35bf28}+1.40\%$
test_sac_speed[reduce-overhead-backward] 5.1615ms 4.1569ms 240.5631 Ops/s 249.3613 Ops/s $\color{#d91a1a}-3.53\%$
test_redq_speed[False-None] 11.0136ms 10.3725ms 96.4092 Ops/s 98.0331 Ops/s $\color{#d91a1a}-1.66\%$
test_redq_speed[False-backward] 18.4281ms 17.7570ms 56.3159 Ops/s 56.9345 Ops/s $\color{#d91a1a}-1.09\%$
test_redq_speed[True-None] 4.8118ms 4.5163ms 221.4215 Ops/s 216.9894 Ops/s $\color{#35bf28}+2.04\%$
test_redq_speed[True-backward] 10.3424ms 9.8759ms 101.2569 Ops/s 99.5666 Ops/s $\color{#35bf28}+1.70\%$
test_redq_speed[reduce-overhead-None] 4.6784ms 4.4253ms 225.9709 Ops/s 216.1830 Ops/s $\color{#35bf28}+4.53\%$
test_redq_speed[reduce-overhead-backward] 10.6261ms 10.1405ms 98.6141 Ops/s 98.1206 Ops/s $\color{#35bf28}+0.50\%$
test_redq_deprec_speed[False-None] 11.3680ms 10.9728ms 91.1342 Ops/s 91.5815 Ops/s $\color{#d91a1a}-0.49\%$
test_redq_deprec_speed[False-backward] 16.5804ms 16.0467ms 62.3182 Ops/s 64.1847 Ops/s $\color{#d91a1a}-2.91\%$
test_redq_deprec_speed[True-None] 4.2302ms 3.7381ms 267.5134 Ops/s 268.3522 Ops/s $\color{#d91a1a}-0.31\%$
test_redq_deprec_speed[True-backward] 8.2400ms 7.8026ms 128.1632 Ops/s 131.2297 Ops/s $\color{#d91a1a}-2.34\%$
test_redq_deprec_speed[reduce-overhead-None] 4.6961ms 3.6452ms 274.3297 Ops/s 275.1115 Ops/s $\color{#d91a1a}-0.28\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.9227ms 7.6962ms 129.9336 Ops/s 122.2117 Ops/s $\textbf{\color{#35bf28}+6.32\%}$
test_td3_speed[False-None] 8.1659ms 7.9464ms 125.8424 Ops/s 127.3121 Ops/s $\color{#d91a1a}-1.15\%$
test_td3_speed[False-backward] 11.3804ms 10.8926ms 91.8053 Ops/s 93.5997 Ops/s $\color{#d91a1a}-1.92\%$
test_td3_speed[True-None] 1.8669ms 1.8193ms 549.6713 Ops/s 552.3696 Ops/s $\color{#d91a1a}-0.49\%$
test_td3_speed[True-backward] 3.7460ms 3.6319ms 275.3358 Ops/s 255.8920 Ops/s $\textbf{\color{#35bf28}+7.60\%}$
test_td3_speed[reduce-overhead-None] 1.8577ms 1.8033ms 554.5278 Ops/s 551.9256 Ops/s $\color{#35bf28}+0.47\%$
test_td3_speed[reduce-overhead-backward] 4.0401ms 3.6546ms 273.6267 Ops/s 272.1385 Ops/s $\color{#35bf28}+0.55\%$
test_cql_speed[False-None] 29.0839ms 25.9803ms 38.4907 Ops/s 38.4453 Ops/s $\color{#35bf28}+0.12\%$
test_cql_speed[False-backward] 35.9965ms 35.3049ms 28.3247 Ops/s 28.0957 Ops/s $\color{#35bf28}+0.82\%$
test_cql_speed[True-None] 12.7521ms 12.3935ms 80.6872 Ops/s 78.3316 Ops/s $\color{#35bf28}+3.01\%$
test_cql_speed[True-backward] 19.2480ms 18.5783ms 53.8263 Ops/s 54.6296 Ops/s $\color{#d91a1a}-1.47\%$
test_cql_speed[reduce-overhead-None] 12.8758ms 12.5394ms 79.7487 Ops/s 79.3339 Ops/s $\color{#35bf28}+0.52\%$
test_cql_speed[reduce-overhead-backward] 18.9482ms 18.6156ms 53.7185 Ops/s 53.1421 Ops/s $\color{#35bf28}+1.08\%$
test_a2c_speed[False-None] 5.7811ms 5.4471ms 183.5850 Ops/s 179.8364 Ops/s $\color{#35bf28}+2.08\%$
test_a2c_speed[False-backward] 12.0723ms 11.8648ms 84.2832 Ops/s 82.2879 Ops/s $\color{#35bf28}+2.42\%$
test_a2c_speed[True-None] 4.0365ms 3.7213ms 268.7209 Ops/s 256.7700 Ops/s $\color{#35bf28}+4.65\%$
test_a2c_speed[True-backward] 9.0765ms 8.7115ms 114.7905 Ops/s 112.0024 Ops/s $\color{#35bf28}+2.49\%$
test_a2c_speed[reduce-overhead-None] 4.0630ms 3.7466ms 266.9103 Ops/s 266.3451 Ops/s $\color{#35bf28}+0.21\%$
test_a2c_speed[reduce-overhead-backward] 9.2809ms 8.8538ms 112.9461 Ops/s 111.3814 Ops/s $\color{#35bf28}+1.40\%$
test_ppo_speed[False-None] 6.2582ms 5.8530ms 170.8533 Ops/s 169.6895 Ops/s $\color{#35bf28}+0.69\%$
test_ppo_speed[False-backward] 13.0161ms 12.5280ms 79.8211 Ops/s 80.8748 Ops/s $\color{#d91a1a}-1.30\%$
test_ppo_speed[True-None] 3.9813ms 3.6413ms 274.6287 Ops/s 268.5727 Ops/s $\color{#35bf28}+2.25\%$
test_ppo_speed[True-backward] 8.9791ms 8.6180ms 116.0359 Ops/s 116.0511 Ops/s $\color{#d91a1a}-0.01\%$
test_ppo_speed[reduce-overhead-None] 3.7087ms 3.6081ms 277.1558 Ops/s 274.0812 Ops/s $\color{#35bf28}+1.12\%$
test_ppo_speed[reduce-overhead-backward] 9.1196ms 8.8305ms 113.2436 Ops/s 112.3673 Ops/s $\color{#35bf28}+0.78\%$
test_reinforce_speed[False-None] 4.9164ms 4.5596ms 219.3194 Ops/s 214.2711 Ops/s $\color{#35bf28}+2.36\%$
test_reinforce_speed[False-backward] 7.9264ms 7.4320ms 134.5536 Ops/s 132.8842 Ops/s $\color{#35bf28}+1.26\%$
test_reinforce_speed[True-None] 4.1329ms 2.9846ms 335.0554 Ops/s 342.3771 Ops/s $\color{#d91a1a}-2.14\%$
test_reinforce_speed[True-backward] 7.9606ms 7.7640ms 128.7990 Ops/s 126.3544 Ops/s $\color{#35bf28}+1.93\%$
test_reinforce_speed[reduce-overhead-None] 3.0918ms 2.8564ms 350.0935 Ops/s 345.4043 Ops/s $\color{#35bf28}+1.36\%$
test_reinforce_speed[reduce-overhead-backward] 8.3935ms 8.0890ms 123.6246 Ops/s 121.3077 Ops/s $\color{#35bf28}+1.91\%$
test_iql_speed[False-None] 20.8779ms 20.0736ms 49.8166 Ops/s 48.8522 Ops/s $\color{#35bf28}+1.97\%$
test_iql_speed[False-backward] 31.1912ms 30.5321ms 32.7525 Ops/s 32.4900 Ops/s $\color{#35bf28}+0.81\%$
test_iql_speed[True-None] 8.8612ms 8.5583ms 116.8458 Ops/s 110.7634 Ops/s $\textbf{\color{#35bf28}+5.49\%}$
test_iql_speed[True-backward] 17.4804ms 16.9364ms 59.0444 Ops/s 57.2525 Ops/s $\color{#35bf28}+3.13\%$
test_iql_speed[reduce-overhead-None] 9.0952ms 8.6078ms 116.1740 Ops/s 115.0365 Ops/s $\color{#35bf28}+0.99\%$
test_iql_speed[reduce-overhead-backward] 18.0222ms 17.4000ms 57.4712 Ops/s 57.1860 Ops/s $\color{#35bf28}+0.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.0998ms 6.0759ms 164.5856 Ops/s 164.8994 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6483ms 0.3373ms 2.9647 KOps/s 3.1203 KOps/s $\color{#d91a1a}-4.99\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5146ms 0.2650ms 3.7732 KOps/s 3.3760 KOps/s $\textbf{\color{#35bf28}+11.77\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0617ms 5.8309ms 171.5007 Ops/s 172.4864 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.0674ms 0.3389ms 2.9507 KOps/s 3.1725 KOps/s $\textbf{\color{#d91a1a}-6.99\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5761ms 0.2940ms 3.4019 KOps/s 3.2527 KOps/s $\color{#35bf28}+4.59\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6922ms 1.4436ms 692.6933 Ops/s 715.3898 Ops/s $\color{#d91a1a}-3.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5527ms 1.3398ms 746.3986 Ops/s 779.9353 Ops/s $\color{#d91a1a}-4.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.9441ms 6.0974ms 164.0036 Ops/s 166.5744 Ops/s $\color{#d91a1a}-1.54\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.2423ms 0.4702ms 2.1268 KOps/s 2.0969 KOps/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7156ms 0.4541ms 2.2022 KOps/s 2.1204 KOps/s $\color{#35bf28}+3.86\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.9365ms 5.8558ms 170.7701 Ops/s 169.4640 Ops/s $\color{#35bf28}+0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1690ms 0.3438ms 2.9088 KOps/s 2.9424 KOps/s $\color{#d91a1a}-1.14\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5741ms 0.3523ms 2.8387 KOps/s 2.8061 KOps/s $\color{#35bf28}+1.16\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0646ms 5.7655ms 173.4448 Ops/s 172.7783 Ops/s $\color{#35bf28}+0.39\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0534ms 0.3722ms 2.6869 KOps/s 3.1059 KOps/s $\textbf{\color{#d91a1a}-13.49\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7040ms 0.3560ms 2.8091 KOps/s 3.1574 KOps/s $\textbf{\color{#d91a1a}-11.03\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0805ms 5.9515ms 168.0261 Ops/s 167.3705 Ops/s $\color{#35bf28}+0.39\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.4705ms 0.5379ms 1.8591 KOps/s 2.2126 KOps/s $\textbf{\color{#d91a1a}-15.98\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8664ms 0.5308ms 1.8839 KOps/s 2.2686 KOps/s $\textbf{\color{#d91a1a}-16.96\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.4097ms 4.9508ms 201.9879 Ops/s 51.0891 Ops/s $\textbf{\color{#35bf28}+295.36\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 7.9089ms 2.3297ms 429.2397 Ops/s 467.4478 Ops/s $\textbf{\color{#d91a1a}-8.17\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.8524ms 1.2066ms 828.8034 Ops/s 785.3739 Ops/s $\textbf{\color{#35bf28}+5.53\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.0193ms 5.0180ms 199.2811 Ops/s 196.4766 Ops/s $\color{#35bf28}+1.43\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.4208ms 2.3640ms 423.0147 Ops/s 459.1949 Ops/s $\textbf{\color{#d91a1a}-7.88\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.2260ms 1.2183ms 820.7921 Ops/s 785.6142 Ops/s $\color{#35bf28}+4.48\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6178s 17.4760ms 57.2212 Ops/s 191.4987 Ops/s $\textbf{\color{#d91a1a}-70.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 11.9360ms 2.1141ms 473.0038 Ops/s 434.1527 Ops/s $\textbf{\color{#35bf28}+8.95\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.2037ms 1.0290ms 971.8092 Ops/s 754.1610 Ops/s $\textbf{\color{#35bf28}+28.86\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 37.2621ms 33.8724ms 29.5226 Ops/s 29.0960 Ops/s $\color{#35bf28}+1.47\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.8479ms 17.3594ms 57.6056 Ops/s 56.4003 Ops/s $\color{#35bf28}+2.14\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.8964ms 34.7172ms 28.8042 Ops/s 28.2830 Ops/s $\color{#35bf28}+1.84\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.5389ms 18.0510ms 55.3987 Ops/s 55.2733 Ops/s $\color{#35bf28}+0.23\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 38.0442ms 36.6186ms 27.3085 Ops/s 26.0321 Ops/s $\color{#35bf28}+4.90\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.4140ms 19.5520ms 51.1458 Ops/s 51.5715 Ops/s $\color{#d91a1a}-0.83\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens