Skip to content

[Test] Add retry decorator to flaky vecnorm test #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Test] Add retry decorator to flaky vecnorm test #3274

vmoens merged 2 commits into from
Dec 31, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
6ec94a6 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3274

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
@vmoens
Update
16b9bef 
[ghstack-poisoned]
This was referenced Dec 31, 2025
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Add retry decorator to flaky vecnorm test
6d908b6 
ghstack-source-id: de9f4e7
Pull-Request: #3274
@vmoens vmoens merged commit 16b9bef into gh/vmoens/174/base Dec 31, 2025
79 of 93 checks passed
@vmoens vmoens deleted the gh/vmoens/174/head branch December 31, 2025 09:17
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}31$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.0658μs 80.7342μs 12.3863 KOps/s 12.3937 KOps/s $\color{#d91a1a}-0.06\%$
test_tensor_to_bytestream_speed[torch.save] 0.1450ms 0.1410ms 7.0928 KOps/s 7.1490 KOps/s $\color{#d91a1a}-0.79\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1194s 0.1191s 8.3994 Ops/s 8.2965 Ops/s $\color{#35bf28}+1.24\%$
test_tensor_to_bytestream_speed[numpy] 2.7287μs 2.7250μs 366.9752 KOps/s 378.8100 KOps/s $\color{#d91a1a}-3.12\%$
test_tensor_to_bytestream_speed[safetensors] 38.2269μs 38.1151μs 26.2363 KOps/s 24.4720 KOps/s $\textbf{\color{#35bf28}+7.21\%}$
test_simple 0.5506s 0.5500s 1.8183 Ops/s 1.7380 Ops/s $\color{#35bf28}+4.62\%$
test_transformed 1.1316s 1.1307s 0.8844 Ops/s 0.8711 Ops/s $\color{#35bf28}+1.52\%$
test_serial 1.7361s 1.7190s 0.5817 Ops/s 0.5921 Ops/s $\color{#d91a1a}-1.75\%$
test_parallel 1.3054s 1.1758s 0.8505 Ops/s 0.8952 Ops/s $\color{#d91a1a}-4.99\%$
test_step_mdp_speed[True-True-True-True-True] 0.2177ms 45.0158μs 22.2144 KOps/s 22.3367 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[True-True-True-True-False] 52.3110μs 25.0475μs 39.9241 KOps/s 39.5168 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[True-True-True-False-True] 69.9110μs 25.1120μs 39.8216 KOps/s 39.3731 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[True-True-True-False-False] 41.7600μs 13.9261μs 71.8077 KOps/s 70.9199 KOps/s $\color{#35bf28}+1.25\%$
test_step_mdp_speed[True-True-False-True-True] 84.4310μs 47.9342μs 20.8619 KOps/s 20.4994 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-True-False-True-False] 56.9810μs 27.7239μs 36.0700 KOps/s 35.9865 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-False-False-True] 58.3320μs 28.3664μs 35.2529 KOps/s 35.2246 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[True-True-False-False-False] 94.6720μs 16.7841μs 59.5800 KOps/s 59.2422 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[True-False-True-True-True] 78.9220μs 50.5734μs 19.7733 KOps/s 19.5055 KOps/s $\color{#35bf28}+1.37\%$
test_step_mdp_speed[True-False-True-True-False] 92.3520μs 30.7775μs 32.4913 KOps/s 32.7571 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[True-False-True-False-True] 57.3310μs 27.9286μs 35.8055 KOps/s 35.7984 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[True-False-True-False-False] 44.1010μs 16.7924μs 59.5508 KOps/s 59.5879 KOps/s $\color{#d91a1a}-0.06\%$
test_step_mdp_speed[True-False-False-True-True] 86.7110μs 52.9982μs 18.8686 KOps/s 18.8473 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[True-False-False-True-False] 0.1015ms 32.8090μs 30.4795 KOps/s 30.1407 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[True-False-False-False-True] 58.3810μs 30.1931μs 33.1201 KOps/s 32.8780 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[True-False-False-False-False] 51.6310μs 19.3148μs 51.7738 KOps/s 51.2376 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[False-True-True-True-True] 85.5120μs 50.0655μs 19.9738 KOps/s 19.5135 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[False-True-True-True-False] 98.5820μs 29.4380μs 33.9697 KOps/s 32.1774 KOps/s $\textbf{\color{#35bf28}+5.57\%}$
test_step_mdp_speed[False-True-True-False-True] 2.3990ms 31.6186μs 31.6270 KOps/s 30.9380 KOps/s $\color{#35bf28}+2.23\%$
test_step_mdp_speed[False-True-True-False-False] 41.5010μs 17.9135μs 55.8239 KOps/s 54.0335 KOps/s $\color{#35bf28}+3.31\%$
test_step_mdp_speed[False-True-False-True-True] 84.7220μs 52.6531μs 18.9922 KOps/s 18.5579 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[False-True-False-True-False] 66.1310μs 32.9375μs 30.3606 KOps/s 29.8841 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[False-True-False-False-True] 74.1610μs 34.2227μs 29.2203 KOps/s 29.2472 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-True-False-False-False] 52.8710μs 20.8257μs 48.0175 KOps/s 47.3184 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[False-False-True-True-True] 82.1220μs 55.8056μs 17.9193 KOps/s 18.1282 KOps/s $\color{#d91a1a}-1.15\%$
test_step_mdp_speed[False-False-True-True-False] 65.7510μs 35.3801μs 28.2645 KOps/s 27.9075 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-False-True-False-True] 71.9420μs 33.7957μs 29.5895 KOps/s 28.8576 KOps/s $\color{#35bf28}+2.54\%$
test_step_mdp_speed[False-False-True-False-False] 49.1810μs 20.6586μs 48.4060 KOps/s 47.8500 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[False-False-False-True-True] 96.9720μs 57.1438μs 17.4997 KOps/s 17.3401 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-False-False-True-False] 67.4720μs 38.2607μs 26.1365 KOps/s 25.9580 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-False-False-False-True] 64.1210μs 35.6042μs 28.0865 KOps/s 27.4394 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[False-False-False-False-False] 65.9110μs 23.3369μs 42.8506 KOps/s 42.1733 KOps/s $\color{#35bf28}+1.61\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8793s 0.7771s 1.2869 Ops/s 1.2925 Ops/s $\color{#d91a1a}-0.43\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7406s 0.6412s 1.5597 Ops/s 1.5577 Ops/s $\color{#35bf28}+0.13\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7811s 1.7044s 0.5867 Ops/s 0.5910 Ops/s $\color{#d91a1a}-0.72\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5583s 1.4752s 0.6779 Ops/s 0.6767 Ops/s $\color{#35bf28}+0.18\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0268s 1.9498s 0.5129 Ops/s 0.5141 Ops/s $\color{#d91a1a}-0.23\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.8068s 1.7304s 0.5779 Ops/s 0.5819 Ops/s $\color{#d91a1a}-0.68\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8707s 4.7186s 0.2119 Ops/s 0.2110 Ops/s $\color{#35bf28}+0.43\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.5915s 4.4984s 0.2223 Ops/s 0.2226 Ops/s $\color{#d91a1a}-0.13\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0789s 2.0247s 0.4939 Ops/s 0.5041 Ops/s $\color{#d91a1a}-2.02\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7598s 1.6845s 0.5936 Ops/s 0.5918 Ops/s $\color{#35bf28}+0.31\%$
test_values[generalized_advantage_estimate-True-True] 10.9764ms 10.3141ms 96.9548 Ops/s 97.1295 Ops/s $\color{#d91a1a}-0.18\%$
test_values[vec_generalized_advantage_estimate-True-True] 14.7302ms 11.3325ms 88.2414 Ops/s 55.6471 Ops/s $\textbf{\color{#35bf28}+58.57\%}$
test_values[td0_return_estimate-False-False] 0.2315ms 0.1315ms 7.6021 KOps/s 7.5745 KOps/s $\color{#35bf28}+0.36\%$
test_values[td1_return_estimate-False-False] 29.4031ms 28.3552ms 35.2669 Ops/s 36.3648 Ops/s $\color{#d91a1a}-3.02\%$
test_values[vec_td1_return_estimate-False-False] 12.2891ms 11.3793ms 87.8789 Ops/s 56.0343 Ops/s $\textbf{\color{#35bf28}+56.83\%}$
test_values[td_lambda_return_estimate-True-False] 42.7962ms 41.5416ms 24.0722 Ops/s 24.6029 Ops/s $\color{#d91a1a}-2.16\%$
test_values[vec_td_lambda_return_estimate-True-False] 13.0643ms 11.5862ms 86.3094 Ops/s 56.1122 Ops/s $\textbf{\color{#35bf28}+53.82\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.3025ms 9.1653ms 109.1075 Ops/s 108.9339 Ops/s $\color{#35bf28}+0.16\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.6927ms 1.4853ms 673.2569 Ops/s 627.5119 Ops/s $\textbf{\color{#35bf28}+7.29\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5729ms 0.4232ms 2.3629 KOps/s 2.3761 KOps/s $\color{#d91a1a}-0.56\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.1425ms 29.7872ms 33.5715 Ops/s 28.8180 Ops/s $\textbf{\color{#35bf28}+16.49\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1374ms 1.7955ms 556.9442 Ops/s 545.4974 Ops/s $\color{#35bf28}+2.10\%$
test_dqn_speed[False-None] 1.5608ms 1.4219ms 703.2601 Ops/s 701.9573 Ops/s $\color{#35bf28}+0.19\%$
test_dqn_speed[False-backward] 1.9743ms 1.9308ms 517.9272 Ops/s 522.7019 Ops/s $\color{#d91a1a}-0.91\%$
test_dqn_speed[True-None] 0.6462ms 0.5275ms 1.8956 KOps/s 1.8871 KOps/s $\color{#35bf28}+0.45\%$
test_dqn_speed[True-backward] 1.0313ms 0.9764ms 1.0242 KOps/s 918.7809 Ops/s $\textbf{\color{#35bf28}+11.47\%}$
test_dqn_speed[reduce-overhead-None] 0.8963ms 0.5227ms 1.9130 KOps/s 1.8620 KOps/s $\color{#35bf28}+2.74\%$
test_dqn_speed[reduce-overhead-backward] 0.9931ms 0.9624ms 1.0390 KOps/s 870.8320 Ops/s $\textbf{\color{#35bf28}+19.32\%}$
test_ddpg_speed[False-None] 3.2651ms 2.8724ms 348.1401 Ops/s 335.9083 Ops/s $\color{#35bf28}+3.64\%$
test_ddpg_speed[False-backward] 4.2200ms 4.0988ms 243.9755 Ops/s 243.5759 Ops/s $\color{#35bf28}+0.16\%$
test_ddpg_speed[True-None] 1.7669ms 1.3689ms 730.4993 Ops/s 697.2633 Ops/s $\color{#35bf28}+4.77\%$
test_ddpg_speed[True-backward] 2.4036ms 2.3572ms 424.2326 Ops/s 344.4446 Ops/s $\textbf{\color{#35bf28}+23.16\%}$
test_ddpg_speed[reduce-overhead-None] 1.7739ms 1.3636ms 733.3618 Ops/s 671.1757 Ops/s $\textbf{\color{#35bf28}+9.27\%}$
test_ddpg_speed[reduce-overhead-backward] 2.5930ms 2.3992ms 416.8111 Ops/s 358.8859 Ops/s $\textbf{\color{#35bf28}+16.14\%}$
test_sac_speed[False-None] 8.5013ms 8.0156ms 124.7563 Ops/s 125.5275 Ops/s $\color{#d91a1a}-0.61\%$
test_sac_speed[False-backward] 11.7490ms 11.2407ms 88.9622 Ops/s 89.0120 Ops/s $\color{#d91a1a}-0.06\%$
test_sac_speed[True-None] 2.5740ms 2.1426ms 466.7321 Ops/s 452.3752 Ops/s $\color{#35bf28}+3.17\%$
test_sac_speed[True-backward] 4.0986ms 3.9937ms 250.3948 Ops/s 227.5283 Ops/s $\textbf{\color{#35bf28}+10.05\%}$
test_sac_speed[reduce-overhead-None] 2.2285ms 2.0992ms 476.3812 Ops/s 454.5263 Ops/s $\color{#35bf28}+4.81\%$
test_sac_speed[reduce-overhead-backward] 4.4332ms 4.0200ms 248.7544 Ops/s 246.5100 Ops/s $\color{#35bf28}+0.91\%$
test_redq_speed[False-None] 10.8819ms 10.3308ms 96.7976 Ops/s 84.9608 Ops/s $\textbf{\color{#35bf28}+13.93\%}$
test_redq_speed[False-backward] 18.5730ms 17.7792ms 56.2454 Ops/s 56.2664 Ops/s $\color{#d91a1a}-0.04\%$
test_redq_speed[True-None] 4.9188ms 4.4125ms 226.6269 Ops/s 209.7604 Ops/s $\textbf{\color{#35bf28}+8.04\%}$
test_redq_speed[True-backward] 10.0867ms 9.8540ms 101.4816 Ops/s 98.7613 Ops/s $\color{#35bf28}+2.75\%$
test_redq_speed[reduce-overhead-None] 4.7066ms 4.3520ms 229.7792 Ops/s 228.7590 Ops/s $\color{#35bf28}+0.45\%$
test_redq_speed[reduce-overhead-backward] 12.3322ms 9.9800ms 100.2005 Ops/s 102.5893 Ops/s $\color{#d91a1a}-2.33\%$
test_redq_deprec_speed[False-None] 11.6172ms 11.0933ms 90.1448 Ops/s 87.1754 Ops/s $\color{#35bf28}+3.41\%$
test_redq_deprec_speed[False-backward] 16.4071ms 16.0329ms 62.3719 Ops/s 60.9383 Ops/s $\color{#35bf28}+2.35\%$
test_redq_deprec_speed[True-None] 4.1369ms 3.6796ms 271.7684 Ops/s 258.6932 Ops/s $\textbf{\color{#35bf28}+5.05\%}$
test_redq_deprec_speed[True-backward] 7.8122ms 7.5408ms 132.6110 Ops/s 122.9099 Ops/s $\textbf{\color{#35bf28}+7.89\%}$
test_redq_deprec_speed[reduce-overhead-None] 3.7753ms 3.5949ms 278.1693 Ops/s 250.0579 Ops/s $\textbf{\color{#35bf28}+11.24\%}$
test_redq_deprec_speed[reduce-overhead-backward] 7.9843ms 7.5540ms 132.3797 Ops/s 114.6700 Ops/s $\textbf{\color{#35bf28}+15.44\%}$
test_td3_speed[False-None] 8.2766ms 8.0904ms 123.6029 Ops/s 123.7209 Ops/s $\color{#d91a1a}-0.10\%$
test_td3_speed[False-backward] 11.5343ms 10.9636ms 91.2105 Ops/s 91.4437 Ops/s $\color{#d91a1a}-0.26\%$
test_td3_speed[True-None] 1.8741ms 1.7940ms 557.4176 Ops/s 543.9987 Ops/s $\color{#35bf28}+2.47\%$
test_td3_speed[True-backward] 3.7550ms 3.6244ms 275.9094 Ops/s 257.2601 Ops/s $\textbf{\color{#35bf28}+7.25\%}$
test_td3_speed[reduce-overhead-None] 1.8397ms 1.7716ms 564.4722 Ops/s 561.5065 Ops/s $\color{#35bf28}+0.53\%$
test_td3_speed[reduce-overhead-backward] 3.8469ms 3.6341ms 275.1726 Ops/s 273.2222 Ops/s $\color{#35bf28}+0.71\%$
test_cql_speed[False-None] 28.9474ms 26.1582ms 38.2290 Ops/s 38.1420 Ops/s $\color{#35bf28}+0.23\%$
test_cql_speed[False-backward] 38.4287ms 35.4878ms 28.1787 Ops/s 28.3153 Ops/s $\color{#d91a1a}-0.48\%$
test_cql_speed[True-None] 12.5884ms 12.2678ms 81.5142 Ops/s 79.6964 Ops/s $\color{#35bf28}+2.28\%$
test_cql_speed[True-backward] 18.5849ms 18.0752ms 55.3244 Ops/s 55.5956 Ops/s $\color{#d91a1a}-0.49\%$
test_cql_speed[reduce-overhead-None] 12.9322ms 12.3987ms 80.6538 Ops/s 80.0456 Ops/s $\color{#35bf28}+0.76\%$
test_cql_speed[reduce-overhead-backward] 18.6141ms 18.2263ms 54.8657 Ops/s 55.6162 Ops/s $\color{#d91a1a}-1.35\%$
test_a2c_speed[False-None] 5.8375ms 5.3954ms 185.3416 Ops/s 176.7465 Ops/s $\color{#35bf28}+4.86\%$
test_a2c_speed[False-backward] 12.0890ms 11.7706ms 84.9571 Ops/s 81.3210 Ops/s $\color{#35bf28}+4.47\%$
test_a2c_speed[True-None] 3.9947ms 3.6616ms 273.1050 Ops/s 260.7044 Ops/s $\color{#35bf28}+4.76\%$
test_a2c_speed[True-backward] 8.8739ms 8.5940ms 116.3600 Ops/s 116.0234 Ops/s $\color{#35bf28}+0.29\%$
test_a2c_speed[reduce-overhead-None] 4.1449ms 3.6850ms 271.3702 Ops/s 267.8525 Ops/s $\color{#35bf28}+1.31\%$
test_a2c_speed[reduce-overhead-backward] 8.8923ms 8.6377ms 115.7717 Ops/s 108.3489 Ops/s $\textbf{\color{#35bf28}+6.85\%}$
test_ppo_speed[False-None] 6.2722ms 5.8687ms 170.3962 Ops/s 168.3016 Ops/s $\color{#35bf28}+1.24\%$
test_ppo_speed[False-backward] 12.6866ms 12.4245ms 80.4863 Ops/s 79.3871 Ops/s $\color{#35bf28}+1.38\%$
test_ppo_speed[True-None] 4.0680ms 3.6044ms 277.4361 Ops/s 276.0484 Ops/s $\color{#35bf28}+0.50\%$
test_ppo_speed[True-backward] 8.6125ms 8.3830ms 119.2891 Ops/s 117.5393 Ops/s $\color{#35bf28}+1.49\%$
test_ppo_speed[reduce-overhead-None] 3.7381ms 3.5590ms 280.9744 Ops/s 278.0750 Ops/s $\color{#35bf28}+1.04\%$
test_ppo_speed[reduce-overhead-backward] 8.8331ms 8.6077ms 116.1752 Ops/s 107.6429 Ops/s $\textbf{\color{#35bf28}+7.93\%}$
test_reinforce_speed[False-None] 4.9449ms 4.5641ms 219.1035 Ops/s 211.4392 Ops/s $\color{#35bf28}+3.62\%$
test_reinforce_speed[False-backward] 7.5945ms 7.3940ms 135.2439 Ops/s 131.2998 Ops/s $\color{#35bf28}+3.00\%$
test_reinforce_speed[True-None] 3.1759ms 2.8660ms 348.9201 Ops/s 334.2469 Ops/s $\color{#35bf28}+4.39\%$
test_reinforce_speed[True-backward] 8.1184ms 7.6733ms 130.3221 Ops/s 123.6139 Ops/s $\textbf{\color{#35bf28}+5.43\%}$
test_reinforce_speed[reduce-overhead-None] 2.9984ms 2.8322ms 353.0879 Ops/s 342.9323 Ops/s $\color{#35bf28}+2.96\%$
test_reinforce_speed[reduce-overhead-backward] 8.4766ms 7.8945ms 126.6704 Ops/s 122.4634 Ops/s $\color{#35bf28}+3.44\%$
test_iql_speed[False-None] 20.8448ms 19.8833ms 50.2936 Ops/s 47.7339 Ops/s $\textbf{\color{#35bf28}+5.36\%}$
test_iql_speed[False-backward] 30.9980ms 30.3386ms 32.9614 Ops/s 32.3841 Ops/s $\color{#35bf28}+1.78\%$
test_iql_speed[True-None] 8.8794ms 8.4641ms 118.1463 Ops/s 112.1803 Ops/s $\textbf{\color{#35bf28}+5.32\%}$
test_iql_speed[True-backward] 17.4036ms 16.6537ms 60.0466 Ops/s 59.3712 Ops/s $\color{#35bf28}+1.14\%$
test_iql_speed[reduce-overhead-None] 11.7091ms 8.8111ms 113.4934 Ops/s 112.4410 Ops/s $\color{#35bf28}+0.94\%$
test_iql_speed[reduce-overhead-backward] 17.1697ms 16.7859ms 59.5737 Ops/s 58.0005 Ops/s $\color{#35bf28}+2.71\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.0432ms 6.0723ms 164.6832 Ops/s 165.1091 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5639ms 0.3278ms 3.0508 KOps/s 3.1052 KOps/s $\color{#d91a1a}-1.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6883ms 0.2871ms 3.4830 KOps/s 2.9545 KOps/s $\textbf{\color{#35bf28}+17.89\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1199ms 5.7933ms 172.6135 Ops/s 172.5915 Ops/s $\color{#35bf28}+0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.9383ms 0.3411ms 2.9320 KOps/s 2.8396 KOps/s $\color{#35bf28}+3.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5443ms 0.3173ms 3.1513 KOps/s 3.6486 KOps/s $\textbf{\color{#d91a1a}-13.63\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6849ms 1.3633ms 733.5224 Ops/s 787.1967 Ops/s $\textbf{\color{#d91a1a}-6.82\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6097ms 1.2831ms 779.3691 Ops/s 843.7231 Ops/s $\textbf{\color{#d91a1a}-7.63\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.8365ms 6.1114ms 163.6297 Ops/s 167.9436 Ops/s $\color{#d91a1a}-2.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1781ms 0.4739ms 2.1101 KOps/s 2.3080 KOps/s $\textbf{\color{#d91a1a}-8.57\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7347ms 0.4750ms 2.1051 KOps/s 2.1701 KOps/s $\color{#d91a1a}-3.00\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.0420ms 5.8382ms 171.2867 Ops/s 171.4430 Ops/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.6970ms 0.3073ms 3.2546 KOps/s 3.0162 KOps/s $\textbf{\color{#35bf28}+7.91\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6027ms 0.3091ms 3.2356 KOps/s 3.4704 KOps/s $\textbf{\color{#d91a1a}-6.76\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1965ms 5.8082ms 172.1691 Ops/s 173.3122 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2279ms 0.3629ms 2.7553 KOps/s 669.4236 Ops/s $\textbf{\color{#35bf28}+311.59\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5602ms 0.3030ms 3.3004 KOps/s 3.1062 KOps/s $\textbf{\color{#35bf28}+6.25\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0425ms 5.9566ms 167.8809 Ops/s 165.7190 Ops/s $\color{#35bf28}+1.30\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9562ms 0.4824ms 2.0731 KOps/s 2.0641 KOps/s $\color{#35bf28}+0.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7071ms 0.4541ms 2.2024 KOps/s 2.2359 KOps/s $\color{#d91a1a}-1.50\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.4470ms 4.9293ms 202.8666 Ops/s 196.0929 Ops/s $\color{#35bf28}+3.45\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 11.2884ms 2.3416ms 427.0639 Ops/s 481.0203 Ops/s $\textbf{\color{#d91a1a}-11.22\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.1248ms 1.1184ms 894.0996 Ops/s 780.0816 Ops/s $\textbf{\color{#35bf28}+14.62\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.2659ms 5.0372ms 198.5229 Ops/s 195.8047 Ops/s $\color{#35bf28}+1.39\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.5337ms 2.2940ms 435.9289 Ops/s 470.8467 Ops/s $\textbf{\color{#d91a1a}-7.42\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.1018ms 1.2456ms 802.8413 Ops/s 773.0443 Ops/s $\color{#35bf28}+3.85\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6115s 17.3821ms 57.5303 Ops/s 53.3150 Ops/s $\textbf{\color{#35bf28}+7.91\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.4265ms 2.1537ms 464.3181 Ops/s 457.9020 Ops/s $\color{#35bf28}+1.40\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.3264ms 1.0248ms 975.7914 Ops/s 976.3823 Ops/s $\color{#d91a1a}-0.06\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.6374ms 34.4763ms 29.0054 Ops/s 28.6290 Ops/s $\color{#35bf28}+1.31\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.8025ms 18.2535ms 54.7840 Ops/s 56.0120 Ops/s $\color{#d91a1a}-2.19\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.2564ms 35.0008ms 28.5708 Ops/s 27.8109 Ops/s $\color{#35bf28}+2.73\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 20.3543ms 18.4950ms 54.0686 Ops/s 54.3538 Ops/s $\color{#d91a1a}-0.52\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 39.6999ms 37.1187ms 26.9406 Ops/s 26.2501 Ops/s $\color{#35bf28}+2.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.5301ms 19.4151ms 51.5062 Ops/s 50.7684 Ops/s $\color{#35bf28}+1.45\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens