Skip to content

[Refactor] Move decorate_thread_sub_func to torchrl.testing.mp_helpers #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Refactor] Move decorate_thread_sub_func to torchrl.testing.mp_helpers #3272

vmoens merged 2 commits into from
Dec 31, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
95a5973 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3272

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
@vmoens
Update
6a3e32d 
[ghstack-poisoned]
This was referenced Dec 31, 2025
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Refactor] Move decorate_thread_sub_func to torchrl.testing.mp_helpers
e3e9e6a 
ghstack-source-id: 6e0eecd
Pull-Request: #3272
@vmoens vmoens merged commit 6a3e32d into gh/vmoens/172/base Dec 31, 2025
78 of 93 checks passed
@vmoens vmoens deleted the gh/vmoens/172/head branch December 31, 2025 09:17
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}16$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 81.5214μs 79.8521μs 12.5231 KOps/s 12.2973 KOps/s $\color{#35bf28}+1.84\%$
test_tensor_to_bytestream_speed[torch.save] 0.1388ms 0.1386ms 7.2147 KOps/s 7.1449 KOps/s $\color{#35bf28}+0.98\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1145s 0.1136s 8.8031 Ops/s 8.3719 Ops/s $\textbf{\color{#35bf28}+5.15\%}$
test_tensor_to_bytestream_speed[numpy] 2.7126μs 2.7082μs 369.2509 KOps/s 379.3246 KOps/s $\color{#d91a1a}-2.66\%$
test_tensor_to_bytestream_speed[safetensors] 40.9960μs 40.2563μs 24.8408 KOps/s 26.9465 KOps/s $\textbf{\color{#d91a1a}-7.81\%}$
test_simple 0.5476s 0.5456s 1.8328 Ops/s 1.7477 Ops/s $\color{#35bf28}+4.87\%$
test_transformed 1.1243s 1.1212s 0.8919 Ops/s 0.8683 Ops/s $\color{#35bf28}+2.72\%$
test_serial 1.6535s 1.6507s 0.6058 Ops/s 0.5940 Ops/s $\color{#35bf28}+2.00\%$
test_parallel 1.1959s 1.1490s 0.8703 Ops/s 0.8347 Ops/s $\color{#35bf28}+4.27\%$
test_step_mdp_speed[True-True-True-True-True] 0.1737ms 43.9211μs 22.7681 KOps/s 22.3927 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[True-True-True-True-False] 61.4910μs 25.3322μs 39.4754 KOps/s 39.5102 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-True-True-False-True] 53.2610μs 25.7750μs 38.7973 KOps/s 39.5168 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-True-True-False-False] 46.8510μs 14.0585μs 71.1316 KOps/s 70.8230 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-False-True-True] 94.0010μs 48.8823μs 20.4573 KOps/s 20.6438 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-True-False-True-False] 57.2510μs 28.1237μs 35.5572 KOps/s 35.4698 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[True-True-False-False-True] 65.6800μs 28.4046μs 35.2056 KOps/s 35.5516 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-False-False-False] 41.1510μs 16.8561μs 59.3256 KOps/s 59.3882 KOps/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-False-True-True-True] 96.0310μs 51.2191μs 19.5240 KOps/s 19.5811 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[True-False-True-True-False] 69.9010μs 30.5900μs 32.6904 KOps/s 32.8062 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-False-True-False-True] 68.6310μs 28.3191μs 35.3118 KOps/s 36.5409 KOps/s $\color{#d91a1a}-3.36\%$
test_step_mdp_speed[True-False-True-False-False] 44.7300μs 16.8189μs 59.4569 KOps/s 60.2785 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-False-False-True-True] 94.3510μs 52.7256μs 18.9661 KOps/s 18.9241 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-False-True-False] 66.1810μs 32.7063μs 30.5752 KOps/s 29.9223 KOps/s $\color{#35bf28}+2.18\%$
test_step_mdp_speed[True-False-False-False-True] 58.8910μs 30.4843μs 32.8038 KOps/s 32.4936 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-False-False-False-False] 56.1210μs 19.4416μs 51.4360 KOps/s 51.6361 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-True-True-True-True] 81.8510μs 51.2595μs 19.5086 KOps/s 19.6532 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[False-True-True-True-False] 60.8110μs 30.7247μs 32.5471 KOps/s 32.7208 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[False-True-True-False-True] 2.3368ms 31.9507μs 31.2983 KOps/s 31.3817 KOps/s $\color{#d91a1a}-0.27\%$
test_step_mdp_speed[False-True-True-False-False] 49.4910μs 18.4964μs 54.0647 KOps/s 54.3561 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-True-False-True-True] 85.0020μs 53.6624μs 18.6350 KOps/s 18.8242 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[False-True-False-True-False] 63.5810μs 33.3153μs 30.0163 KOps/s 30.3175 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[False-True-False-False-True] 64.5810μs 34.2388μs 29.2066 KOps/s 29.3927 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[False-True-False-False-False] 50.3710μs 21.2990μs 46.9505 KOps/s 47.8730 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[False-False-True-True-True] 92.6820μs 57.1969μs 17.4835 KOps/s 17.8648 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[False-False-True-True-False] 72.7910μs 36.3032μs 27.5458 KOps/s 28.2458 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[False-False-True-False-True] 67.9310μs 34.3590μs 29.1045 KOps/s 29.6087 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[False-False-True-False-False] 49.7010μs 21.2320μs 47.0986 KOps/s 47.5657 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[False-False-False-True-True] 0.1073ms 58.3075μs 17.1505 KOps/s 17.3915 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-False-False-True-False] 74.6610μs 38.5865μs 25.9158 KOps/s 25.7602 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[False-False-False-False-True] 68.8410μs 36.6971μs 27.2501 KOps/s 27.9431 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[False-False-False-False-False] 55.9810μs 23.8816μs 41.8732 KOps/s 42.5158 KOps/s $\color{#d91a1a}-1.51\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8832s 0.7836s 1.2762 Ops/s 1.2821 Ops/s $\color{#d91a1a}-0.46\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7471s 0.6505s 1.5372 Ops/s 1.5502 Ops/s $\color{#d91a1a}-0.84\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7900s 1.7131s 0.5837 Ops/s 0.5876 Ops/s $\color{#d91a1a}-0.66\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5634s 1.4824s 0.6746 Ops/s 0.6750 Ops/s $\color{#d91a1a}-0.07\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0362s 1.9550s 0.5115 Ops/s 0.5145 Ops/s $\color{#d91a1a}-0.58\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.8063s 1.7266s 0.5792 Ops/s 0.5825 Ops/s $\color{#d91a1a}-0.57\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.7665s 4.6640s 0.2144 Ops/s 0.2134 Ops/s $\color{#35bf28}+0.45\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.6307s 4.4899s 0.2227 Ops/s 0.2205 Ops/s $\color{#35bf28}+1.01\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.1306s 2.0154s 0.4962 Ops/s 0.4902 Ops/s $\color{#35bf28}+1.22\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.8965s 1.7130s 0.5838 Ops/s 0.5822 Ops/s $\color{#35bf28}+0.28\%$
test_values[generalized_advantage_estimate-True-True] 9.9599ms 9.8122ms 101.9134 Ops/s 100.8198 Ops/s $\color{#35bf28}+1.08\%$
test_values[vec_generalized_advantage_estimate-True-True] 19.4824ms 17.1629ms 58.2653 Ops/s 89.3227 Ops/s $\textbf{\color{#d91a1a}-34.77\%}$
test_values[td0_return_estimate-False-False] 0.2541ms 0.1249ms 8.0086 KOps/s 7.8767 KOps/s $\color{#35bf28}+1.67\%$
test_values[td1_return_estimate-False-False] 26.7185ms 25.9595ms 38.5216 Ops/s 37.8836 Ops/s $\color{#35bf28}+1.68\%$
test_values[vec_td1_return_estimate-False-False] 18.8271ms 17.8063ms 56.1600 Ops/s 88.7995 Ops/s $\textbf{\color{#d91a1a}-36.76\%}$
test_values[td_lambda_return_estimate-True-False] 39.8790ms 38.6502ms 25.8731 Ops/s 25.5899 Ops/s $\color{#35bf28}+1.11\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.7964ms 17.7214ms 56.4290 Ops/s 90.4335 Ops/s $\textbf{\color{#d91a1a}-37.60\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.7488ms 8.6095ms 116.1505 Ops/s 114.1758 Ops/s $\color{#35bf28}+1.73\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.9146ms 1.4941ms 669.3022 Ops/s 658.7090 Ops/s $\color{#35bf28}+1.61\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4999ms 0.4018ms 2.4891 KOps/s 2.5165 KOps/s $\color{#d91a1a}-1.09\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 30.5855ms 29.6191ms 33.7620 Ops/s 33.5309 Ops/s $\color{#35bf28}+0.69\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1197ms 1.7828ms 560.9159 Ops/s 552.9800 Ops/s $\color{#35bf28}+1.44\%$
test_dqn_speed[False-None] 1.5112ms 1.3670ms 731.5515 Ops/s 730.2049 Ops/s $\color{#35bf28}+0.18\%$
test_dqn_speed[False-backward] 1.9337ms 1.8600ms 537.6413 Ops/s 538.9943 Ops/s $\color{#d91a1a}-0.25\%$
test_dqn_speed[True-None] 0.6840ms 0.5211ms 1.9189 KOps/s 1.8700 KOps/s $\color{#35bf28}+2.62\%$
test_dqn_speed[True-backward] 1.3689ms 0.9698ms 1.0312 KOps/s 1.0141 KOps/s $\color{#35bf28}+1.68\%$
test_dqn_speed[reduce-overhead-None] 0.6125ms 0.5191ms 1.9265 KOps/s 1.9128 KOps/s $\color{#35bf28}+0.72\%$
test_dqn_speed[reduce-overhead-backward] 0.9934ms 0.9479ms 1.0550 KOps/s 982.4363 Ops/s $\textbf{\color{#35bf28}+7.39\%}$
test_ddpg_speed[False-None] 3.1990ms 2.8446ms 351.5422 Ops/s 349.1336 Ops/s $\color{#35bf28}+0.69\%$
test_ddpg_speed[False-backward] 4.3172ms 4.0191ms 248.8139 Ops/s 251.5504 Ops/s $\color{#d91a1a}-1.09\%$
test_ddpg_speed[True-None] 1.7542ms 1.3682ms 730.9033 Ops/s 727.5504 Ops/s $\color{#35bf28}+0.46\%$
test_ddpg_speed[True-backward] 2.4021ms 2.3497ms 425.5940 Ops/s 350.0146 Ops/s $\textbf{\color{#35bf28}+21.59\%}$
test_ddpg_speed[reduce-overhead-None] 1.7597ms 1.3884ms 720.2364 Ops/s 728.6170 Ops/s $\color{#d91a1a}-1.15\%$
test_ddpg_speed[reduce-overhead-backward] 2.3919ms 2.3212ms 430.8033 Ops/s 393.9599 Ops/s $\textbf{\color{#35bf28}+9.35\%}$
test_sac_speed[False-None] 8.1269ms 7.7056ms 129.7765 Ops/s 127.1277 Ops/s $\color{#35bf28}+2.08\%$
test_sac_speed[False-backward] 11.0080ms 10.8282ms 92.3512 Ops/s 91.0175 Ops/s $\color{#35bf28}+1.47\%$
test_sac_speed[True-None] 2.5177ms 2.1157ms 472.6674 Ops/s 476.8243 Ops/s $\color{#d91a1a}-0.87\%$
test_sac_speed[True-backward] 4.0344ms 3.9407ms 253.7623 Ops/s 250.5683 Ops/s $\color{#35bf28}+1.27\%$
test_sac_speed[reduce-overhead-None] 2.2295ms 2.0976ms 476.7376 Ops/s 467.0213 Ops/s $\color{#35bf28}+2.08\%$
test_sac_speed[reduce-overhead-backward] 4.0541ms 3.9443ms 253.5286 Ops/s 221.4465 Ops/s $\textbf{\color{#35bf28}+14.49\%}$
test_redq_speed[False-None] 14.5378ms 10.3488ms 96.6296 Ops/s 96.6975 Ops/s $\color{#d91a1a}-0.07\%$
test_redq_speed[False-backward] 24.8645ms 17.9200ms 55.8035 Ops/s 56.9624 Ops/s $\color{#d91a1a}-2.03\%$
test_redq_speed[True-None] 4.7397ms 4.3240ms 231.2685 Ops/s 227.7004 Ops/s $\color{#35bf28}+1.57\%$
test_redq_speed[True-backward] 10.0876ms 9.5486ms 104.7278 Ops/s 101.0802 Ops/s $\color{#35bf28}+3.61\%$
test_redq_speed[reduce-overhead-None] 4.8959ms 4.3505ms 229.8593 Ops/s 235.9623 Ops/s $\color{#d91a1a}-2.59\%$
test_redq_speed[reduce-overhead-backward] 9.9402ms 9.6688ms 103.4255 Ops/s 96.4929 Ops/s $\textbf{\color{#35bf28}+7.18\%}$
test_redq_deprec_speed[False-None] 11.2788ms 10.7435ms 93.0796 Ops/s 91.1586 Ops/s $\color{#35bf28}+2.11\%$
test_redq_deprec_speed[False-backward] 15.8055ms 15.4702ms 64.6403 Ops/s 63.8046 Ops/s $\color{#35bf28}+1.31\%$
test_redq_deprec_speed[True-None] 3.7442ms 3.5642ms 280.5712 Ops/s 269.5062 Ops/s $\color{#35bf28}+4.11\%$
test_redq_deprec_speed[True-backward] 7.7513ms 7.4599ms 134.0494 Ops/s 130.9746 Ops/s $\color{#35bf28}+2.35\%$
test_redq_deprec_speed[reduce-overhead-None] 3.8393ms 3.5193ms 284.1503 Ops/s 278.2426 Ops/s $\color{#35bf28}+2.12\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.7506ms 7.5254ms 132.8832 Ops/s 121.3743 Ops/s $\textbf{\color{#35bf28}+9.48\%}$
test_td3_speed[False-None] 7.9966ms 7.8123ms 128.0027 Ops/s 126.9257 Ops/s $\color{#35bf28}+0.85\%$
test_td3_speed[False-backward] 11.0410ms 10.6249ms 94.1186 Ops/s 94.5740 Ops/s $\color{#d91a1a}-0.48\%$
test_td3_speed[True-None] 1.8173ms 1.7738ms 563.7672 Ops/s 555.7731 Ops/s $\color{#35bf28}+1.44\%$
test_td3_speed[True-backward] 4.0015ms 3.5684ms 280.2338 Ops/s 251.2458 Ops/s $\textbf{\color{#35bf28}+11.54\%}$
test_td3_speed[reduce-overhead-None] 1.8079ms 1.7731ms 563.9933 Ops/s 561.7854 Ops/s $\color{#35bf28}+0.39\%$
test_td3_speed[reduce-overhead-backward] 3.7652ms 3.6275ms 275.6706 Ops/s 262.1542 Ops/s $\textbf{\color{#35bf28}+5.16\%}$
test_cql_speed[False-None] 28.5956ms 25.6571ms 38.9755 Ops/s 38.2567 Ops/s $\color{#35bf28}+1.88\%$
test_cql_speed[False-backward] 39.4617ms 34.6285ms 28.8779 Ops/s 28.9610 Ops/s $\color{#d91a1a}-0.29\%$
test_cql_speed[True-None] 12.6093ms 12.2108ms 81.8945 Ops/s 78.3902 Ops/s $\color{#35bf28}+4.47\%$
test_cql_speed[True-backward] 18.3322ms 17.9524ms 55.7029 Ops/s 56.1478 Ops/s $\color{#d91a1a}-0.79\%$
test_cql_speed[reduce-overhead-None] 12.8350ms 12.4285ms 80.4601 Ops/s 80.8196 Ops/s $\color{#d91a1a}-0.44\%$
test_cql_speed[reduce-overhead-backward] 18.2031ms 17.8373ms 56.0624 Ops/s 55.9061 Ops/s $\color{#35bf28}+0.28\%$
test_a2c_speed[False-None] 5.8578ms 5.3879ms 185.6004 Ops/s 180.9493 Ops/s $\color{#35bf28}+2.57\%$
test_a2c_speed[False-backward] 11.9457ms 11.6275ms 86.0033 Ops/s 84.6258 Ops/s $\color{#35bf28}+1.63\%$
test_a2c_speed[True-None] 3.7664ms 3.6509ms 273.9019 Ops/s 263.9538 Ops/s $\color{#35bf28}+3.77\%$
test_a2c_speed[True-backward] 9.1053ms 8.5320ms 117.2056 Ops/s 111.7843 Ops/s $\color{#35bf28}+4.85\%$
test_a2c_speed[reduce-overhead-None] 4.1105ms 3.6998ms 270.2847 Ops/s 270.5478 Ops/s $\color{#d91a1a}-0.10\%$
test_a2c_speed[reduce-overhead-backward] 9.1591ms 8.6250ms 115.9422 Ops/s 113.6437 Ops/s $\color{#35bf28}+2.02\%$
test_ppo_speed[False-None] 6.0277ms 5.8095ms 172.1325 Ops/s 169.5990 Ops/s $\color{#35bf28}+1.49\%$
test_ppo_speed[False-backward] 12.7591ms 12.2025ms 81.9504 Ops/s 81.9024 Ops/s $\color{#35bf28}+0.06\%$
test_ppo_speed[True-None] 3.7655ms 3.6058ms 277.3277 Ops/s 278.7200 Ops/s $\color{#d91a1a}-0.50\%$
test_ppo_speed[True-backward] 8.6253ms 8.3777ms 119.3647 Ops/s 117.8236 Ops/s $\color{#35bf28}+1.31\%$
test_ppo_speed[reduce-overhead-None] 3.8783ms 3.5701ms 280.1081 Ops/s 277.8199 Ops/s $\color{#35bf28}+0.82\%$
test_ppo_speed[reduce-overhead-backward] 8.7644ms 8.6089ms 116.1595 Ops/s 110.6645 Ops/s $\color{#35bf28}+4.97\%$
test_reinforce_speed[False-None] 4.9100ms 4.5292ms 220.7896 Ops/s 219.0606 Ops/s $\color{#35bf28}+0.79\%$
test_reinforce_speed[False-backward] 7.4659ms 7.2824ms 137.3178 Ops/s 136.2111 Ops/s $\color{#35bf28}+0.81\%$
test_reinforce_speed[True-None] 3.1762ms 2.8620ms 349.4072 Ops/s 350.8108 Ops/s $\color{#d91a1a}-0.40\%$
test_reinforce_speed[True-backward] 8.0820ms 7.6686ms 130.4021 Ops/s 130.7663 Ops/s $\color{#d91a1a}-0.28\%$
test_reinforce_speed[reduce-overhead-None] 3.1353ms 2.8168ms 355.0098 Ops/s 346.0113 Ops/s $\color{#35bf28}+2.60\%$
test_reinforce_speed[reduce-overhead-backward] 8.0194ms 7.8311ms 127.6958 Ops/s 123.7795 Ops/s $\color{#35bf28}+3.16\%$
test_iql_speed[False-None] 25.1255ms 20.2670ms 49.3414 Ops/s 51.1789 Ops/s $\color{#d91a1a}-3.59\%$
test_iql_speed[False-backward] 36.4570ms 30.5904ms 32.6900 Ops/s 33.3106 Ops/s $\color{#d91a1a}-1.86\%$
test_iql_speed[True-None] 8.8202ms 8.4301ms 118.6223 Ops/s 116.6074 Ops/s $\color{#35bf28}+1.73\%$
test_iql_speed[True-backward] 17.1585ms 16.5299ms 60.4965 Ops/s 57.7556 Ops/s $\color{#35bf28}+4.75\%$
test_iql_speed[reduce-overhead-None] 9.2079ms 8.4887ms 117.8037 Ops/s 115.9908 Ops/s $\color{#35bf28}+1.56\%$
test_iql_speed[reduce-overhead-backward] 17.5397ms 17.0604ms 58.6153 Ops/s 57.1304 Ops/s $\color{#35bf28}+2.60\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.1572ms 6.2018ms 161.2436 Ops/s 161.0517 Ops/s $\color{#35bf28}+0.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6136ms 0.3507ms 2.8512 KOps/s 2.8361 KOps/s $\color{#35bf28}+0.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7586ms 0.3102ms 3.2237 KOps/s 2.9747 KOps/s $\textbf{\color{#35bf28}+8.37\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2005ms 5.9416ms 168.3035 Ops/s 170.0903 Ops/s $\color{#d91a1a}-1.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.9486ms 0.2812ms 3.5568 KOps/s 2.9939 KOps/s $\textbf{\color{#35bf28}+18.80\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6903ms 0.3157ms 3.1678 KOps/s 3.2410 KOps/s $\color{#d91a1a}-2.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4469ms 1.2173ms 821.4718 Ops/s 813.7257 Ops/s $\color{#35bf28}+0.95\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4959ms 1.1463ms 872.3866 Ops/s 872.6691 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 10.3325ms 6.2539ms 159.9001 Ops/s 165.2589 Ops/s $\color{#d91a1a}-3.24\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1301ms 0.4833ms 2.0692 KOps/s 2.1193 KOps/s $\color{#d91a1a}-2.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8048ms 0.4686ms 2.1342 KOps/s 2.1601 KOps/s $\color{#d91a1a}-1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.1128ms 5.9579ms 167.8439 Ops/s 167.9920 Ops/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6051ms 0.3011ms 3.3213 KOps/s 3.1377 KOps/s $\textbf{\color{#35bf28}+5.85\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5720ms 0.2821ms 3.5447 KOps/s 3.3338 KOps/s $\textbf{\color{#35bf28}+6.33\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1637ms 5.8547ms 170.8023 Ops/s 170.3814 Ops/s $\color{#35bf28}+0.25\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7420s 1.5965ms 626.3540 Ops/s 3.4458 KOps/s $\textbf{\color{#d91a1a}-81.82\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5797ms 0.3572ms 2.7993 KOps/s 2.5411 KOps/s $\textbf{\color{#35bf28}+10.16\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1831ms 6.0806ms 164.4569 Ops/s 163.5578 Ops/s $\color{#35bf28}+0.55\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0101ms 0.5257ms 1.9023 KOps/s 1.9607 KOps/s $\color{#d91a1a}-2.98\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6920ms 0.4924ms 2.0308 KOps/s 2.0354 KOps/s $\color{#d91a1a}-0.23\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.3568ms 4.9617ms 201.5433 Ops/s 195.8754 Ops/s $\color{#35bf28}+2.89\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.9177ms 2.0460ms 488.7670 Ops/s 479.7268 Ops/s $\color{#35bf28}+1.88\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.0967ms 1.2013ms 832.4386 Ops/s 835.6064 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 6.3838ms 4.9792ms 200.8369 Ops/s 196.7249 Ops/s $\color{#35bf28}+2.09\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 10.0637ms 2.1050ms 475.0545 Ops/s 481.3206 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.1351ms 1.2322ms 811.5636 Ops/s 810.3783 Ops/s $\color{#35bf28}+0.15\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.5766s 16.5877ms 60.2857 Ops/s 53.3652 Ops/s $\textbf{\color{#35bf28}+12.97\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 4.0749ms 1.9414ms 515.1043 Ops/s 463.0117 Ops/s $\textbf{\color{#35bf28}+11.25\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.4487ms 1.0276ms 973.1686 Ops/s 948.3716 Ops/s $\color{#35bf28}+2.61\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.0944ms 33.7736ms 29.6089 Ops/s 28.8004 Ops/s $\color{#35bf28}+2.81\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.9373ms 17.6617ms 56.6196 Ops/s 56.0359 Ops/s $\color{#35bf28}+1.04\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.5272ms 34.8895ms 28.6619 Ops/s 27.5719 Ops/s $\color{#35bf28}+3.95\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.8329ms 17.9239ms 55.7915 Ops/s 55.2877 Ops/s $\color{#35bf28}+0.91\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 39.4747ms 36.4439ms 27.4394 Ops/s 26.2296 Ops/s $\color{#35bf28}+4.61\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.2886ms 19.7489ms 50.6357 Ops/s 50.9864 Ops/s $\color{#d91a1a}-0.69\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens