Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wheel testing logic to downstream repos #116

Merged
merged 13 commits into from
Jul 21, 2023
Merged

Move wheel testing logic to downstream repos #116

merged 13 commits into from
Jul 21, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 19, 2023 •
edited
Loading

This PR is the testing companion to #97. It also introduces a standardized publish workflow that may be reused between pure and manylinux builds (see #89).

@vyasr vyasr added the improvement Improves an existing functionality label Jul 19, 2023
@vyasr vyasr self-assigned this Jul 19, 2023
@vyasr vyasr mentioned this pull request Jul 19, 2023
Merged
@vyasr
Copy link
Contributor Author

vyasr commented Jul 19, 2023

I need to rename the extension from .yml to .yaml. I'll do that before merging this PR, but first waiting for CI to pass on all the dependent PRs.

divyegala
divyegala reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add RAPIDS_ARTIFACT_DIR to wheels-build.yaml? I forgot to add it

.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
.github/workflows/wheels-test.yaml Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Jul 20, 2023

Could you please also add RAPIDS_ARTIFACT_DIR to wheels-build.yaml? I forgot to add it

Done in #117

@vyasr vyasr mentioned this pull request Jul 20, 2023
Merged
3 tasks
@vyasr vyasr mentioned this pull request Jul 21, 2023
Merged
@vyasr vyasr merged commit 8fc876d into branch-23.08 Jul 21, 2023
@vyasr vyasr mentioned this pull request Jul 24, 2023
Closed
@vyasr vyasr deleted the feat/local-test branch July 25, 2023 21:28
@vyasr vyasr mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees

@vyasr vyasr

Labels
improvement Improves an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @divyegala @wence-