support invalid handle exception from rclpy in the action LoadComposableNodes #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shutdown event will be invoked while loading nodes into a composable node then is a high change to raise
rclpy.InvalidHandle
exception. My pull request fixes that.But ain't sure is a good way - maybe is not a problem here but in rclpy?
In my opinion in this code should be
return self.context.ok() and self.service_is_ready()
similar to the above linewhile …
.Maybe is a problem with priority - the ros node in the launcher shouldn't be turned off before running coroutines. But I don't know is easy to fix that (or is this a current case).
Steps to reproduce the bug
Code
ros2 test.launch.py
Before fix
After fix