-
Notifications
You must be signed in to change notification settings - Fork 50
Add ECMWF non-stationary gravity wave scheme option #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mdtoyNOAA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition to the UGWP suite.
|
Please add a doc section in ecmwf_ngw_emc to acknowledge that: This non-stationary GWD module was obtained by Fanglin Yang from ECMWF, with permission for operational use at NCEP. We would like to thank Andy Brown, Michael Sleigh, Peter Bechtold, and Nils Wedi at ECMWF for their support in porting this code to the UFS. |
@BoYang-NOAA Please also add relevant references in the doc section. Please refer to the header of the source code pasted below. Please describe briefly major changes we made for UFS installation.!**** GWDRAG_WMS MASTER ROUTINE FOR CUMULUS MASSFLUX-SCHEME ! Original Fortran Code by J. SCINOCCIA ! PURPOSE ! THIS ROUTINE COMPUTES NON-OROGRAPHIC GRAVITY WAVE DRAG ! REFERENCE: Orr, A., P. Bechtold, J. Scinoccia, M. Ern, M. Janiskova, 2010: ! LAUNCH SPECTRUM - GENERALIZED DESAUBIES |
|
Sure. Will work on it.
…On Mon, Apr 28, 2025 at 9:19 AM Fanglin Yang ***@***.***> wrote:
*yangfanglin* left a comment (ufs-community/ccpp-physics#273)
<#273 (comment)>
@BoYang-NOAA <https://github.com/BoYang-NOAA> Please also add relevant
references in the doc section
—
Reply to this email directly, view it on GitHub
<#273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARTOITIRHWM7HJ5CRRWVWHT23YTF7AVCNFSM6AAAAAB3T46O46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZVGIYTQNRTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@BoYang-NOAA I'll approve this once I hear from @mzhangw about the Doxygen changes. |
The requested changes have been made. There is no need to re-review.
|
@BoYang-NOAA There are a lot of commented-out lines of code. Could you please remove unnecessary ones? |
|
Combined into #295. Keeping open until merged. |
Add ECMWF Non-stationary gravity wave scheme in UGWDV1 gravity wave suite. If do_ngw_ec is set to true, use the ECMWF NGWD scheme. Conversely, if do_ngw_ec is false, use the original UGWDv1 NGWD scheme. do_ngw_ec is set to false by default.