Skip to content

Conversation

@BoYang-NOAA
Copy link
Collaborator

@BoYang-NOAA BoYang-NOAA commented Apr 22, 2025

Add ECMWF Non-stationary gravity wave scheme in UGWDV1 gravity wave suite. If do_ngw_ec is set to true, use the ECMWF NGWD scheme. Conversely, if do_ngw_ec is false, use the original UGWDv1 NGWD scheme. do_ngw_ec is set to false by default.

Copy link
Collaborator

@mdtoyNOAA mdtoyNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition to the UGWP suite.

@BoYang-NOAA BoYang-NOAA requested a review from yangfanglin April 23, 2025 15:36
@yangfanglin
Copy link
Collaborator

Please add a doc section in ecmwf_ngw_emc to acknowledge that: This non-stationary GWD module was obtained by Fanglin Yang from ECMWF, with permission for operational use at NCEP. We would like to thank Andy Brown, Michael Sleigh, Peter Bechtold, and Nils Wedi at ECMWF for their support in porting this code to the UFS.

@yangfanglin
Copy link
Collaborator

yangfanglin commented Apr 28, 2025

@BoYang-NOAA Please also add relevant references in the doc section. Please refer to the header of the source code pasted below. Please describe briefly major changes we made for UFS installation.

!**** GWDRAG_WMS MASTER ROUTINE FOR CUMULUS MASSFLUX-SCHEME

! Original Fortran Code by J. SCINOCCIA
! Rewritten in IFS format by A. ORR E.C.M.W.F. August 2008

! PURPOSE
! -------

! THIS ROUTINE COMPUTES NON-OROGRAPHIC GRAVITY WAVE DRAG
! AFTER SCINOCCA (2003) AND Mc LANDRESS AND SCINOCCIA (JAS 2005)
! HYDROSTATIC NON-ROTATIONAL SIMPLIFIED VERSION OF THE
! WARNER AND MCINTYRE (1996) NON-OROGRAPHIC GRAVITY WAVE PARAMETERIZATION
! CONSTANTS HAVE BEEN OPTIMIZED FOLLOWING M. ERN ET AL. (ATMOS. CHEM. PHYS. 2006)

! REFERENCE: Orr, A., P. Bechtold, J. Scinoccia, M. Ern, M. Janiskova, 2010:
! Improved middle atmosphere climate and analysis in the ECMWF forecasting system
! through a non-orographic gravity wave parametrization. J. Climate., 23, 5905-5926.

! LAUNCH SPECTRUM - GENERALIZED DESAUBIES
! INCLUDES A CRITICAL-LEVEL CORRECTION THAT PREVENTS THE
! MOMEMTUM DEPOSITION IN EACH AZIMUTH FROM DRIVING THE FLOW TO SPEEDS FASTER
! THAN THE PHASE SPEED OF THE WAVES, I.E. WHEN WAVES BREAK THEY DRAG THE MEAN
! FLOW TOWARDS THEIR PHASE SPEED - NOT PAST IT.

@BoYang-NOAA
Copy link
Collaborator Author

BoYang-NOAA commented Apr 28, 2025 via email

@grantfirl
Copy link
Collaborator

@BoYang-NOAA I'll approve this once I hear from @mzhangw about the Doxygen changes.

@grantfirl grantfirl dismissed mzhangw’s stale review May 16, 2025 15:17

The requested changes have been made. There is no need to re-review.

@rhaesung
Copy link
Collaborator

@BoYang-NOAA There are a lot of commented-out lines of code. Could you please remove unnecessary ones?

@grantfirl
Copy link
Collaborator

Combined into #295. Keeping open until merged.

@rhaesung rhaesung merged commit e8133cc into ufs-community:ufs/dev Jul 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants