Repository navigation
apollo_network_benchmark: add get_tcp_stats function - #11562
Closed
sirandreww-starkware wants to merge 1 commit into
Conversation
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
sirandreww-starkware
marked this pull request as ready for review
January 8, 2026 17:43
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_tcp_metrics_definitions
branch
from
February 16, 2026 09:10
d938017 to
e743c39
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_get_tcp_stats_function
branch
from
February 16, 2026 09:10
78ebb8b to
062bff3
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_tcp_metrics_definitions
branch
from
February 19, 2026 07:24
e743c39 to
1c3918f
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_get_tcp_stats_function
branch
from
February 19, 2026 07:24
062bff3 to
17e3518
Compare
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Adds a new, currently unused
/procparsing helper; no behavior changes unless it is later integrated into the metrics pipeline.Overview
Adds a new Linux-only helper
get_tcp_stats()insystem_metrics.rsthat parses/proc/net/snmpto extract TCPOutSegsandRetransSegs, with warning logs on read/parse/format issues.The function is currently unused (guarded by
#[allow(dead_code)]), so runtime behavior of the benchmark node is unchanged until it’s wired into metric collection.Written by Cursor Bugbot for commit 17e3518. This will update automatically on new commits. Configure here.