[sirandreww-starkware]

Note

Medium Risk
Adds new async loops and query/response handling in the benchmark node; mistakes could cause hangs, hot loops, or misleading benchmark results, but it’s isolated to benchmarking code.

Overview
Implements the previously todo!() NetworkProtocol::ReveresedSqmr path in the broadcast network stress test node by registering SQMR client/server channels and wiring them into new MessageSender::ReveresedSqmr and MessageReceiver::ReveresedSqmr variants.

Adds a ReveresedSqmrSender wrapper that tracks the latest incoming server query and replies with broadcast messages, and adds a receiver loop that continuously opens client queries and streams responses into the benchmark’s message callback with basic error logging.

^{Written by Cursor Bugbot for commit 87d3238. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555 👈 (View in Graphite)
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

Tight busy-loop on repeated connection failure

Medium Severity

The ReveresedSqmr receiver's outer loop has no delay or backoff in the Err(e) arm. Since send_new_query fails immediately (the underlying mpsc::SendError is non-blocking), a persistent failure will cause a tight CPU-spinning loop that also floods logs with error messages. A small sleep or backoff in the error branch would prevent this.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs#L214-L221