Skip to content

apollo_network_benchmark: added SQMR session metrics - #11546

Closed
sirandreww-starkware wants to merge 1 commit into
01-07-apollo_network_benchmark_added_broadcast_topic_metricsfrom
01-07-apollo_network_benchmark_added_sqmr_session_metrics
Closed

sirandreww-starkware wants to merge 1 commit into
01-07-apollo_network_benchmark_added_broadcast_topic_metricsfrom
01-07-apollo_network_benchmark_added_sqmr_session_metrics

Conversation

@sirandreww-starkware

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor

Note

Low Risk
Metrics-only change that wires two new gauges into existing NetworkMetrics, with minimal impact beyond observability.

Overview
The broadcast network stress-test node now publishes SQMR session visibility by adding network_active_inbound_sessions and network_active_outbound_sessions gauges.

create_network_metrics() now populates NetworkMetrics.sqmr_metrics (previously None) with these gauges so the benchmark can report active SQMR session counts alongside existing peer/broadcast metrics.

Written by Cursor Bugbot for commit 204a8fa. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

sirandreww-starkware commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
@sirandreww-starkware
sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label Feb 8, 2026
@github-actions github-actions Bot closed this Feb 16, 2026
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_topic_metrics branch from 1f0509d to ab1a950 Compare February 16, 2026 09:10
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from 0e49478 to 7137381 Compare February 16, 2026 09:10
@github-actions github-actions Bot removed the stale label Feb 17, 2026
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from 7137381 to 9f1fb1f Compare February 19, 2026 07:24
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from 9f1fb1f to ce5b018 Compare February 19, 2026 08:04
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from ce5b018 to 74f56ff Compare March 16, 2026 15:13
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_topic_metrics branch from 5095a65 to 6d10db7 Compare March 22, 2026 17:09
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from 74f56ff to 6772656 Compare March 22, 2026 17:09
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_topic_metrics branch from 6d10db7 to e200357 Compare March 30, 2026 11:08
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_sqmr_session_metrics branch from 6772656 to 204a8fa Compare March 30, 2026 11:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants