Repository navigation
apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum - #11550
Closed
Conversation
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
sirandreww-starkware
marked this pull request as ready for review
January 8, 2026 17:43
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_protocol_constant
branch
from
February 16, 2026 09:10
4083c5d to
9b3fdfa
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
February 16, 2026 09:10
91b2e93 to
28715e4
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
February 19, 2026 07:24
28715e4 to
f4b4c71
Compare
This was referenced Feb 19, 2026
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
February 19, 2026 08:04
f4b4c71 to
98a30f3
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_protocol_constant
branch
from
February 19, 2026 08:04
766686d to
3abc921
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
March 16, 2026 15:13
98a30f3 to
f24b8da
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_protocol_constant
branch
from
March 22, 2026 17:09
13f2310 to
78fe3c9
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
March 22, 2026 17:09
f24b8da to
2c00b15
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_protocol_constant
branch
from
March 30, 2026 11:08
78fe3c9 to
45c4eeb
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
branch
from
March 30, 2026 11:08
2c00b15 to
1d03a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds a new user-selectable protocol flag that currently triggers a runtime
todo!()panic if used; otherwise the existing gossipsub path is unchanged.Overview
Adds a new
sqmrvariant to the CLI-configurableNetworkProtocolenum.Updates
register_protocol_channelsto handleNetworkProtocol::Sqmr, but the SQMR path is currently atodo!()placeholder that will panic if selected.Written by Cursor Bugbot for commit 1d03a2a. This will update automatically on new commits. Configure here.