Skip to content

apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum - #11550

Closed
sirandreww-starkware wants to merge 1 commit into
01-08-apollo_network_benchmark_add_sqmr_protocol_constantfrom
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum
Closed

sirandreww-starkware wants to merge 1 commit into
01-08-apollo_network_benchmark_add_sqmr_protocol_constantfrom
01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum

Conversation

@sirandreww-starkware

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Adds a new user-selectable protocol flag that currently triggers a runtime todo!() panic if used; otherwise the existing gossipsub path is unchanged.

Overview
Adds a new sqmr variant to the CLI-configurable NetworkProtocol enum.

Updates register_protocol_channels to handle NetworkProtocol::Sqmr, but the SQMR path is currently a todo!() placeholder that will panic if selected.

Written by Cursor Bugbot for commit 1d03a2a. This will update automatically on new commits. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

sirandreww-starkware commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware
sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:43
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label Feb 8, 2026
@github-actions github-actions Bot closed this Feb 16, 2026
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 4083c5d to 9b3fdfa Compare February 16, 2026 09:10
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from 91b2e93 to 28715e4 Compare February 16, 2026 09:10
@github-actions github-actions Bot removed the stale label Feb 17, 2026
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from 28715e4 to f4b4c71 Compare February 19, 2026 07:24
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from f4b4c71 to 98a30f3 Compare February 19, 2026 08:04
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 766686d to 3abc921 Compare February 19, 2026 08:04
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from 98a30f3 to f24b8da Compare March 16, 2026 15:13
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 13f2310 to 78fe3c9 Compare March 22, 2026 17:09
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from f24b8da to 2c00b15 Compare March 22, 2026 17:09
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 78fe3c9 to 45c4eeb Compare March 30, 2026 11:08
@sirandreww-starkware
sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_variant_to_networkprotocol_enum branch from 2c00b15 to 1d03a2a Compare March 30, 2026 11:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants