fix(mapgen-studio): wrap AppFooter test in TooltipProvider and add @ alias to vitest config#1612
Merged
Merged
Conversation
This was referenced Jun 12, 2026
Merged
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Owner
Author
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/app-shell
branch
from
June 12, 2026 20:44
9d1803f to
bfd599f
Compare
mateicanavra
force-pushed
the
design/test-harness-fix
branch
from
June 12, 2026 20:44
5f03a26 to
43e4ec2
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/app-shell
to
graphite-base/1612
June 12, 2026 21:04
…er harness Fixes two test-infra regressions from the redesign stack: - vitest.config.ts: add the @/* -> src alias to the mapgen-studio project so the shadcn components/ui -> @/lib/utils import chain resolves (regression from the design-system slice, which added @ to tsconfig + vite but not vitest). - AppFooter.test.tsx: wrap the render in TooltipProvider (Radix Tooltip migration). Remaining: 8 AppFooter assertions still red — they assert on diagnostic strings (run requestId, failure reason) that the Radix Tooltip migration moved into hover-only TooltipContent (absent from static markup AND from screen readers). That is the a11y/parity gap the review flagged; its faithful fix (mirror the diagnostic into the trigger aria-label, in-DOM) is queued for the P4 craft/a11y pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/test-harness-fix
branch
from
June 12, 2026 21:06
43e4ec2 to
a410a28
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
AppFooterinTooltipProviderwithin the test render helper, which is required now that the component uses shadcn tooltip primitives internally. Also adds a@/*path alias to themapgen-studiovitest project config to mirror the app's TypeScript and Vite alias, allowing vitest to correctly resolve thecomponents/ui→@/lib/utilsimport chain used by shadcn components.